Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-27 17:16:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: socket posts delete/restore/purge so tid is not necessary (#8607)

Browse Source 
* refactor: socket posts delete/restore/purge so tid is not necessary

* refactor: stop trying to be fancy

* fix: tests to not pass in tid into posts.deletePosts

* fix: some more unnecessary tid passing
This commit is contained in:
Julian Lam
2020-09-02 21:51:35 -04:00
committed by GitHub
parent dfeb65bb95
commit f743f92088
4 changed files with 14 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/socket.io/posts/tools.js
View File

@@ -89,7 +89,7 @@ module.exports = function (SocketPosts) {
await deleteOrRestoreTopicOf(params.command, data.pid, socket);
}
websockets.in('topic_' + data.tid).emit(params.event, postData);
websockets.in('topic_' + postData.tid).emit(params.event, postData);
await events.log({
type: params.type,
@@ -114,7 +114,7 @@ module.exports = function (SocketPosts) {
}
for (const pid of data.pids) {
/* eslint-disable no-await-in-loop */
await SocketPosts[command](socket, { pid: pid, tid: data.tid });
await SocketPosts[command](socket, { pid: pid });
}
}
@@ -134,8 +134,8 @@ module.exports = function (SocketPosts) {
await posts.tools.purge(socket.uid, data.pid);
websockets.in('topic_' + data.tid).emit('event:post_purged', postData);
const topicData = await topics.getTopicFields(data.tid, ['title', 'cid']);
websockets.in('topic_' + postData.tid).emit('event:post_purged', postData);
const topicData = await topics.getTopicFields(postData.tid, ['title', 'cid']);
await events.log({
type: 'post-purge',