Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't chop off colons when generating titles as they could interfere with emoji

Browse Source
This commit is contained in:
Julian Lam
2024-11-14 15:07:42 -05:00
parent b25aa3364a
commit f449fafccf
2 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/activitypub/helpers.js
View File

@@ -343,9 +343,6 @@ Helpers.generateTitle = (html) => {
title = sentences.shift();
}
// Trim certain punctuation marks
title = title.trim().replace(/[:]$/, '');
// Truncate down if too long
if (title.length > meta.config.maximumTitleLength) {
title = `${title.slice(0, meta.config.maximumTitleLength - 3)}...`;

5
test/activitypub.js
View File

@@ -127,11 +127,8 @@ describe('ActivityPub integration', () => {
// other sentence ending symbols
['Lorem ipsum dolor sit amet, consectetur adipiscing elit? Etiam a ex pellentesque, fringilla lorem non, blandit est. Nulla facilisi. Curabitur cursus neque vel enim semper, id lacinia elit facilisis. Vestibulum turpis orci, efficitur ut semper eu, faucibus eu turpis. Praesent eu odio non libero gravida tempor. Ut porta pellentesque orci. In porta nunc eget tincidunt interdum. Curabitur vel dui nec libero tempus porttitor. Phasellus tincidunt, diam id viverra suscipit, est diam maximus purus, in vestibulum dui ligula vel libero. Sed tempus finibus ante, sit amet consequat magna facilisis eget. Proin ullamcorper, velit sit amet feugiat varius, massa sem aliquam dui, non aliquam augue velit vel est. Phasellus eu sapien in purus feugiat scelerisque congue id velit. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos.', 'Lorem ipsum dolor sit amet, consectetur adipiscing elit?'],
// should trim non-sentence-ending punctuation
['<span>one two three:</span><p>four five six</p>', 'one two three'],
// Content after line breaks can be discarded
['<p>Intro text<br /><a href=\"https://example.org/\">example.org/</span></a></p><p>more text</p>', 'Intro text'],
['<p>Intro text<br /><a href="https://example.org/">example.org/</span></a></p><p>more text</p>', 'Intro text'],
// HTML without outer wrapping element
['Lorem ipsum dolor <span>sit amet</span>', 'Lorem ipsum dolor sit amet'],