Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 19:46:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: 7638, returnTo accidentally saved into user hash

Browse Source
This commit is contained in:
Julian Lam
2019-05-24 11:23:55 -04:00
parent 157b921e14
commit f321b426b1
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/controllers/authentication.js
View File

@@ -9,7 +9,7 @@ var _ = require('lodash');
var db = require('../database'); var db = require('../database');
var meta = require('../meta'); var meta = require('../meta');
var user = require('../user'); var user = require('../user').async;
var plugins = require('../plugins'); var plugins = require('../plugins');
var utils = require('../utils'); var utils = require('../utils');
var translator = require('../translator'); var translator = require('../translator');
@@ -180,7 +180,7 @@ authenticationController.registerComplete = function (req, res, next) {
} }
}; };
async.parallel(callbacks, function (_blank, err) { async.parallel(callbacks, async function (_blank, err) {
if (err.length) { if (err.length) {
err = err.filter(Boolean).map(function (err) { err = err.filter(Boolean).map(function (err) {
return err.message; return err.message;
@@ -200,6 +200,7 @@ authenticationController.registerComplete = function (req, res, next) {
const payload = req.session.registration; const payload = req.session.registration;
const uid = payload.uid; const uid = payload.uid;
delete payload.uid; delete payload.uid;
delete payload.returnTo;
Object.keys(payload).forEach((prop) => { Object.keys(payload).forEach((prop) => {
if (typeof payload[prop] === 'boolean') { if (typeof payload[prop] === 'boolean') {
@@ -207,7 +208,8 @@ authenticationController.registerComplete = function (req, res, next) {
} }
}); });
user.setUserFields(uid, payload, done); await user.setUserFields(uid, payload);
done();
} }
}); });
}); });