Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #8728, dont add admins to table

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-10-08 18:08:04 -04:00
parent b3ed26ac2c
commit f259063f08
3 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
public/language/en-GB/admin/manage/privileges.json
View File

@@ -48,5 +48,6 @@
"alert.confirm-copyToAllGroup": "Are you sure you wish to apply this group's privilege set to <strong>all categories</strong>?", "alert.confirm-copyToAllGroup": "Are you sure you wish to apply this group's privilege set to <strong>all categories</strong>?",
"alert.confirm-copyToChildren": "Are you sure you wish to apply this privilege set to <strong>all descendant (child) categories</strong>?", "alert.confirm-copyToChildren": "Are you sure you wish to apply this privilege set to <strong>all descendant (child) categories</strong>?",
"alert.confirm-copyToChildrenGroup": "Are you sure you wish to apply this group's privilege set to <strong>all descendant (child) categories</strong>?", "alert.confirm-copyToChildrenGroup": "Are you sure you wish to apply this group's privilege set to <strong>all descendant (child) categories</strong>?",
"alert.no-undo": "<em>This action cannot be undone.</em>" "alert.no-undo": "<em>This action cannot be undone.</em>",
"alert.admin-warning": "Administrators implicitly get all privileges"
} }

6
public/src/admin/manage/privileges.js
View File

@@ -256,6 +256,12 @@ define('admin/manage/privileges', [
inputEl.focus(); inputEl.focus();
autocomplete.group(inputEl, function (ev, ui) { autocomplete.group(inputEl, function (ev, ui) {
if (ui.item.group.name === 'administrators') {
return app.alert({
type: 'warning',
message: '[[admin/manage/privileges:alert.admin-warning]]',
});
}
addGroupToCategory(ui.item.group.name, function () { addGroupToCategory(ui.item.group.name, function () {
modal.modal('hide'); modal.modal('hide');
}); });

5
public/src/modules/autocomplete.js
View File

@@ -21,8 +21,7 @@ define('autocomplete', function () {
handleOnSelect(input, onselect, event, ui); handleOnSelect(input, onselect, event, ui);
}, },
source: function (request, response) { source: function (request, response) {
params.query = params.query || request.term; params.query = request.term;
params.paginate = params.paginate || false;
socket.emit('user.search', params, function (err, result) { socket.emit('user.search', params, function (err, result) {
if (err) { if (err) {
@@ -51,8 +50,6 @@ define('autocomplete', function () {
} }
$('.ui-autocomplete a').attr('data-ajaxify', 'false'); $('.ui-autocomplete a').attr('data-ajaxify', 'false');
delete params.query;
delete params.paginate;
}); });
}, },
}); });