Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: pass only needed data

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-07-29 21:48:31 -04:00
parent 9f346c53ab
commit f1974fb900
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/groups/search.js
View File

@@ -58,7 +58,6 @@ module.exports = function (Groups) {
...data, ...data,
paginate: false, paginate: false,
hardCap: -1, hardCap: -1,
groupName: data.groupName,
}); });
const uids = results.users.map(user => user && user.uid); const uids = results.users.map(user => user && user.uid);

7
src/socket.io/groups.js
View File

@@ -326,7 +326,6 @@ SocketGroups.loadMore = async (socket, data) => {
}; };
SocketGroups.searchMembers = async (socket, data) => { SocketGroups.searchMembers = async (socket, data) => {
data.uid = socket.uid;
const [isOwner, isMember, isAdmin] = await Promise.all([ const [isOwner, isMember, isAdmin] = await Promise.all([
groups.ownership.isOwner(socket.uid, data.groupName), groups.ownership.isOwner(socket.uid, data.groupName),
groups.isMember(socket.uid, data.groupName), groups.isMember(socket.uid, data.groupName),
@@ -335,7 +334,11 @@ SocketGroups.searchMembers = async (socket, data) => {
if (!isOwner && !isMember && !isAdmin) { if (!isOwner && !isMember && !isAdmin) {
throw new Error('[[error:no-privileges]]'); throw new Error('[[error:no-privileges]]');
} }
return await groups.searchMembers(data); return await groups.searchMembers({
uid: socket.uid,
query: data.query,
groupName: data.groupName,
});
}; };
SocketGroups.loadMoreMembers = async (socket, data) => { SocketGroups.loadMoreMembers = async (socket, data) => {