Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove dead picture upload code #8260

Browse Source
This commit is contained in:
Julian Lam
2020-04-17 10:08:18 -04:00
parent 058a15dbb2
commit ef52461fb6
3 changed files with 0 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/controllers/accounts/edit.js
View File

@@ -7,7 +7,6 @@ const helpers = require('../helpers');
const groups = require('../../groups'); const groups = require('../../groups');
const accountHelpers = require('./helpers'); const accountHelpers = require('./helpers');
const privileges = require('../../privileges'); const privileges = require('../../privileges');
const file = require('../../file');
const editController = module.exports; const editController = module.exports;
@@ -125,46 +124,3 @@ async function getUserData(req) {
userData.hasPassword = await user.hasPassword(userData.uid); userData.hasPassword = await user.hasPassword(userData.uid);
return userData; return userData;
} }
editController.uploadPicture = async function (req, res, next) {
const userPhoto = req.files.files[0];
try {
const updateUid = await user.getUidByUserslug(req.params.userslug);
const isAllowed = await privileges.users.canEdit(req.uid, updateUid);
if (!isAllowed) {
return helpers.notAllowed(req, res);
}
await user.checkMinReputation(req.uid, updateUid, 'min:rep:profile-picture');
const image = await user.uploadCroppedPicture({
uid: updateUid,
file: userPhoto,
});
res.json([{
name: userPhoto.name,
url: image.url,
}]);
} catch (err) {
next(err);
} finally {
file.delete(userPhoto.path);
}
};
editController.uploadCoverPicture = async function (req, res, next) {
var params = JSON.parse(req.body.params);
var coverPhoto = req.files.files[0];
try {
await user.checkMinReputation(req.uid, params.uid, 'min:rep:cover-picture');
const image = await user.updateCoverPicture({
file: coverPhoto,
uid: params.uid,
});
res.json([{
url: image.url,
}]);
} catch (err) {
next(err);
} finally {
file.delete(coverPhoto.path);
}
};

18
src/controllers/groups.js
View File

@@ -118,21 +118,3 @@ groupsController.members = async function (req, res, next) {
breadcrumbs: breadcrumbs, breadcrumbs: breadcrumbs,
}); });
}; };
groupsController.uploadCover = async function (req, res, next) {
const params = JSON.parse(req.body.params);
try {
const isOwner = await groups.ownership.isOwner(req.uid, params.groupName);
if (!isOwner) {
throw new Error('[[error:no-privileges]]');
}
const image = await groups.updateCover(req.uid, {
file: req.files.files[0],
groupName: params.groupName,
});
res.json([{ url: image.url }]);
} catch (err) {
next(err);
}
};

4
src/routes/api.js
View File

@@ -40,8 +40,4 @@ module.exports = function (app, middleware, controllers) {
var middlewares = [middleware.maintenanceMode, multipartMiddleware, middleware.validateFiles, middleware.applyCSRF]; var middlewares = [middleware.maintenanceMode, multipartMiddleware, middleware.validateFiles, middleware.applyCSRF];
router.post('/post/upload', middlewares, uploadsController.uploadPost); router.post('/post/upload', middlewares, uploadsController.uploadPost);
router.post('/topic/thumb/upload', middlewares, uploadsController.uploadThumb); router.post('/topic/thumb/upload', middlewares, uploadsController.uploadThumb);
router.post('/user/:userslug/uploadpicture', middlewares.concat([middleware.exposeUid, middleware.authenticate, middleware.canViewUsers, middleware.checkAccountPermissions]), controllers.accounts.edit.uploadPicture);
router.post('/user/:userslug/uploadcover', middlewares.concat([middleware.exposeUid, middleware.authenticate, middleware.canViewUsers, middleware.checkAccountPermissions]), controllers.accounts.edit.uploadCoverPicture);
router.post('/groups/uploadpicture', middlewares.concat([middleware.authenticate]), controllers.groups.uploadCover);
}; };