Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use groupslug:groupname for search and acp page

Browse Source 
dont need to load all names which includes privilege groups
This commit is contained in:
Barış Soner Uşaklı
2024-04-08 16:18:26 -04:00
parent 7033d11ede
commit ee5c021c47
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/controllers/admin/groups.js
View File

@@ -62,14 +62,13 @@ groupsController.get = async function (req, res, next) {
}; };
async function getGroupNames() { async function getGroupNames() {
const groupNames = await db.getSortedSetRange('groups:createtime', 0, -1); const groupNames = Object.values(await db.getObject('groupslug:groupname'));
return groupNames.filter(name => ( return groupNames.filter(name => (
name !== 'registered-users' && name !== 'registered-users' &&
name !== 'verified-users' && name !== 'verified-users' &&
name !== 'unverified-users' && name !== 'unverified-users' &&
name !== groups.BANNED_USERS && name !== groups.BANNED_USERS
!groups.isPrivilegeGroup(name) )).sort((a, b) => a.toLowerCase().localeCompare(b.toLowerCase()));
));
} }
groupsController.getCSV = async function (req, res) { groupsController.getCSV = async function (req, res) {

8
src/groups/search.js
View File

@@ -9,13 +9,13 @@ module.exports = function (Groups) {
return []; return [];
} }
query = String(query).toLowerCase(); query = String(query).toLowerCase();
let groupNames = await db.getSortedSetRange('groups:createtime', 0, -1); let groupNames = Object.values(await db.getObject('groupslug:groupname'));
if (!options.hideEphemeralGroups) { if (!options.hideEphemeralGroups) {
groupNames = Groups.ephemeralGroups.concat(groupNames); groupNames = Groups.ephemeralGroups.concat(groupNames);
} }
groupNames = groupNames.filter(name => name.toLowerCase().includes(query) && groupNames = groupNames.filter(
name !== Groups.BANNED_USERS && // hide banned-users in searches name => name.toLowerCase().includes(query) && name !== Groups.BANNED_USERS // hide banned-users in searches
!Groups.isPrivilegeGroup(name)); );
groupNames = groupNames.slice(0, 100); groupNames = groupNames.slice(0, 100);
let groupsData; let groupsData;