Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 19:15:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #5186

Browse Source 
On socket.io connection, all clients join a room pertaining to
their express session id. We use this room to keep track of any
sessions in different browser windows (but the same cookie jar),
so if a login/logout occurs, we can throw a session mismatch
modal.

This room can also be used to emit messages across windows/tabs...
This commit is contained in:
Julian Lam
2016-11-11 16:47:59 -05:00
parent 38f11f8c28
commit ede7a71db7
4 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/controllers/authentication.js
View File

@@ -15,6 +15,8 @@ var plugins = require('../plugins');
var utils = require('../../public/src/utils');
var Password = require('../password');
var sockets = require('../socket.io');
var authenticationController = {};
authenticationController.register = function (req, res, next) {
@@ -326,6 +328,10 @@ authenticationController.onSuccessfulLogin = function (req, uid, callback) {
if (err) {
return callback(err);
}
// Force session check for all connected socket.io clients with the same session id
sockets.in('sess_' + req.sessionID).emit('checkSession', uid);
plugins.fireHook('action:user.loggedIn', uid);
callback();
});
@@ -405,7 +411,9 @@ authenticationController.localLogin = function (req, username, password, next) {
authenticationController.logout = function (req, res, next) {
if (req.user && parseInt(req.user.uid, 10) > 0 && req.sessionID) {
var uid = parseInt(req.user.uid, 10);
user.auth.revokeSession(req.sessionID, uid, function (err) {
var sessionID = req.sessionID;
user.auth.revokeSession(sessionID, uid, function (err) {
if (err) {
return next(err);
}
@@ -416,6 +424,9 @@ authenticationController.logout = function (req, res, next) {
plugins.fireHook('static:user.loggedOut', {req: req, res: res, uid: uid}, function () {
res.status(200).send('');
// Force session check for all connected socket.io clients with the same session id
sockets.in('sess_' + sessionID).emit('checkSession', 0);
});
});
} else {