Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-30 10:35:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: resolveId method, add hostname verification

Browse Source
This commit is contained in:
Julian Lam
2024-02-21 10:58:20 -05:00
parent 42a0924137
commit ed4ccbfccc
4 changed files with 63 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/activitypub/notes.js
View File

@@ -14,11 +14,6 @@ const slugify = require('../slugify');
const activitypub = module.parent.exports;
const Notes = module.exports;
Notes.resolveId = async (uid, id) => {
({ id } = await activitypub.get('uid', uid, id));
return id;
};
// todo: when asserted, notes aren't added to a global sorted set
// also, db.exists call is probably expensive
Notes.assert = async (uid, input, options = {}) => {
@@ -28,8 +23,13 @@ Notes.assert = async (uid, input, options = {}) => {
await Promise.all(input.map(async (item) => {
let id = activitypub.helpers.isUri(item) ? item : item.pid;
if (activitypub.helpers.isUri(id)) {
id = await Notes.resolveId(uid, id);
id = await activitypub.resolveId(uid, id);
if (!id) {
winston.warn(`[activitypub/notes.assert] Not asserting ${id}`);
return;
}
}
const key = `post:${id}`;
const exists = await db.exists(key);
winston.verbose(`[activitypub/notes.assert] Asserting note id ${id}`);