Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-12-20 15:30:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: object destructuring overwriting type parameter

Browse Source 
also check for valid types in generateExport
This commit is contained in:
Barış Soner Uşaklı
2023-02-27 09:10:53 -05:00
parent 8cf4a6f62e
commit ec58700f6d
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/api/users.js
View File

@@ -443,6 +443,10 @@ usersAPI.changePicture = async (caller, data) => {
}; };
usersAPI.generateExport = async (caller, { uid, type }) => { usersAPI.generateExport = async (caller, { uid, type }) => {
const validTypes = ['profile', 'posts', 'uploads'];
if (!validTypes.includes(type)) {
throw new Error('[[error:invalid-data]]');
}
const count = await db.incrObjectField('locks', `export:${uid}${type}`); const count = await db.incrObjectField('locks', `export:${uid}${type}`);
if (count > 1) { if (count > 1) {
throw new Error('[[error:already-exporting]]'); throw new Error('[[error:already-exporting]]');

2
src/socket.io/user/profile.js
View File

@@ -74,6 +74,6 @@ module.exports = function (SocketUser) {
await user.isAdminOrSelf(socket.uid, data.uid); await user.isAdminOrSelf(socket.uid, data.uid);
api.users.generateExport(socket, { type, ...data }); api.users.generateExport(socket, { type, uid: data.uid });
} }
}; };