Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

breaking: remove socket.emit('posts.upvote')

Browse Source 
socket.emit('posts.downvote')
socket.emit('posts.unvote')
This commit is contained in:
Barış Soner Uşaklı
2021-12-09 19:12:49 -05:00
parent 8427c5d9db
commit ec1d5e38da
2 changed files with 45 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/socket.io/posts/votes.js
View File

@@ -5,9 +5,6 @@ const user = require('../../user');
const posts = require('../../posts');
const privileges = require('../../privileges');
const meta = require('../../meta');
const api = require('../../api');
const sockets = require('..');
module.exports = function (SocketPosts) {
SocketPosts.getVoters = async function (socket, data) {
@@ -61,19 +58,4 @@ module.exports = function (SocketPosts) {
}));
return result;
};
SocketPosts.upvote = async function (socket, data) {
sockets.warnDeprecated(socket, 'PUT /api/v3/posts/:pid/vote');
return await api.posts.upvote(socket, data);
};
SocketPosts.downvote = async function (socket, data) {
sockets.warnDeprecated(socket, 'PUT /api/v3/posts/:pid/vote');
return await api.posts.downvote(socket, data);
};
SocketPosts.unvote = async function (socket, data) {
sockets.warnDeprecated(socket, 'DELETE /api/v3/posts/:pid/vote');
return await api.posts.unvote(socket, data);
};
};

103
test/posts.js
View File

@@ -163,36 +163,33 @@ describe('Post\'s', () => {
});
describe('voting', () => {
it('should fail to upvote post if group does not have upvote permission', (done) => {
privileges.categories.rescind(['groups:posts:upvote', 'groups:posts:downvote'], cid, 'registered-users', (err) => {
assert.ifError(err);
socketPosts.upvote({ uid: voterUid }, { pid: postData.pid, room_id: 'topic_1' }, (err) => {
assert.equal(err.message, '[[error:no-privileges]]');
socketPosts.downvote({ uid: voterUid }, { pid: postData.pid, room_id: 'topic_1' }, (err) => {
assert.equal(err.message, '[[error:no-privileges]]');
privileges.categories.give(['groups:posts:upvote', 'groups:posts:downvote'], cid, 'registered-users', (err) => {
assert.ifError(err);
done();
});
});
});
});
it('should fail to upvote post if group does not have upvote permission', async () => {
await privileges.categories.rescind(['groups:posts:upvote', 'groups:posts:downvote'], cid, 'registered-users');
let err;
try {
await apiPosts.upvote({ uid: voterUid }, { pid: postData.pid, room_id: 'topic_1' });
} catch (_err) {
err = _err;
}
assert.equal(err.message, '[[error:no-privileges]]');
try {
await apiPosts.downvote({ uid: voterUid }, { pid: postData.pid, room_id: 'topic_1' });
} catch (_err) {
err = _err;
}
assert.equal(err.message, '[[error:no-privileges]]');
await privileges.categories.give(['groups:posts:upvote', 'groups:posts:downvote'], cid, 'registered-users');
});
it('should upvote a post', (done) => {
socketPosts.upvote({ uid: voterUid }, { pid: postData.pid, room_id: 'topic_1' }, (err, result) => {
assert.ifError(err);
assert.equal(result.post.upvotes, 1);
assert.equal(result.post.downvotes, 0);
assert.equal(result.post.votes, 1);
assert.equal(result.user.reputation, 1);
posts.hasVoted(postData.pid, voterUid, (err, data) => {
assert.ifError(err);
assert.equal(data.upvoted, true);
assert.equal(data.downvoted, false);
done();
});
});
it('should upvote a post', async () => {
const result = await apiPosts.upvote({ uid: voterUid }, { pid: postData.pid, room_id: 'topic_1' });
assert.equal(result.post.upvotes, 1);
assert.equal(result.post.downvotes, 0);
assert.equal(result.post.votes, 1);
assert.equal(result.user.reputation, 1);
const data = await posts.hasVoted(postData.pid, voterUid);
assert.equal(data.upvoted, true);
assert.equal(data.downvoted, false);
});
it('should get voters', (done) => {
@@ -215,36 +212,26 @@ describe('Post\'s', () => {
});
});
it('should unvote a post', (done) => {
socketPosts.unvote({ uid: voterUid }, { pid: postData.pid, room_id: 'topic_1' }, (err, result) => {
assert.ifError(err);
assert.equal(result.post.upvotes, 0);
assert.equal(result.post.downvotes, 0);
assert.equal(result.post.votes, 0);
assert.equal(result.user.reputation, 0);
posts.hasVoted(postData.pid, voterUid, (err, data) => {
assert.ifError(err);
assert.equal(data.upvoted, false);
assert.equal(data.downvoted, false);
done();
});
});
it('should unvote a post', async () => {
const result = await apiPosts.unvote({ uid: voterUid }, { pid: postData.pid, room_id: 'topic_1' });
assert.equal(result.post.upvotes, 0);
assert.equal(result.post.downvotes, 0);
assert.equal(result.post.votes, 0);
assert.equal(result.user.reputation, 0);
const data = await posts.hasVoted(postData.pid, voterUid);
assert.equal(data.upvoted, false);
assert.equal(data.downvoted, false);
});
it('should downvote a post', (done) => {
socketPosts.downvote({ uid: voterUid }, { pid: postData.pid, room_id: 'topic_1' }, (err, result) => {
assert.ifError(err);
assert.equal(result.post.upvotes, 0);
assert.equal(result.post.downvotes, 1);
assert.equal(result.post.votes, -1);
assert.equal(result.user.reputation, -1);
posts.hasVoted(postData.pid, voterUid, (err, data) => {
assert.ifError(err);
assert.equal(data.upvoted, false);
assert.equal(data.downvoted, true);
done();
});
});
it('should downvote a post', async () => {
const result = await apiPosts.downvote({ uid: voterUid }, { pid: postData.pid, room_id: 'topic_1' });
assert.equal(result.post.upvotes, 0);
assert.equal(result.post.downvotes, 1);
assert.equal(result.post.votes, -1);
assert.equal(result.user.reputation, -1);
const data = await posts.hasVoted(postData.pid, voterUid);
assert.equal(data.upvoted, false);
assert.equal(data.downvoted, true);
});
it('should prevent downvoting more than total daily limit', async () => {
@@ -257,7 +244,7 @@ describe('Post\'s', () => {
content: 'raw content',
});
try {
await socketPosts.downvote({ uid: voterUid }, { pid: p1.pid, room_id: 'topic_1' });
await apiPosts.downvote({ uid: voterUid }, { pid: p1.pid, room_id: 'topic_1' });
} catch (_err) {
err = _err;
}
@@ -275,7 +262,7 @@ describe('Post\'s', () => {
content: 'raw content',
});
try {
await socketPosts.downvote({ uid: voterUid }, { pid: p1.pid, room_id: 'topic_1' });
await apiPosts.downvote({ uid: voterUid }, { pid: p1.pid, room_id: 'topic_1' });
} catch (_err) {
err = _err;
}