Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: temporarily deny handling non-public notes

Browse Source
This commit is contained in:
Julian Lam
2024-02-21 14:58:52 -05:00
parent 49c69a0f6a
commit eaba2aa37f
3 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
public/language/en-GB/error.json
View File

@@ -283,5 +283,6 @@
"activitypub.get-failed": "Unable to retrieve the specified resource.", "activitypub.get-failed": "Unable to retrieve the specified resource.",
"activitypub.pubKey-not-found": "Unable to resolve public key, so payload verification cannot take place.", "activitypub.pubKey-not-found": "Unable to resolve public key, so payload verification cannot take place.",
"activitypub.origin-mismatch": "The received object's origin does not match the sender's origin", "activitypub.origin-mismatch": "The received object's origin does not match the sender's origin",
"activitypub.actor-mismatch": "The received activity is being carried out by an actor that is different from expected." "activitypub.actor-mismatch": "The received activity is being carried out by an actor that is different from expected.",
"activitypub.not-implemented": "The request was denied because it or an aspect of it is not implemented by the recipient server"
} }

5
src/activitypub/inbox.js
View File

@@ -19,6 +19,11 @@ inbox.create = async (req) => {
const { object } = req.body; const { object } = req.body;
const postData = await activitypub.mocks.post(object); const postData = await activitypub.mocks.post(object);
// Temporary, reject non-public notes.
if (![...postData._activitypub.to, ...postData._activitypub.cc].includes(activitypub._constants.publicAddress)) {
throw new Error('[[error:activitypub.not-implemented]]');
}
if (postData) { if (postData) {
await activitypub.notes.assert(0, [postData]); await activitypub.notes.assert(0, [postData]);
const tid = await activitypub.notes.assertTopic(0, postData.pid); const tid = await activitypub.notes.assertTopic(0, postData.pid);

9
src/controllers/activitypub/index.js
View File

@@ -4,6 +4,7 @@ const nconf = require('nconf');
const user = require('../../user'); const user = require('../../user');
const activitypub = require('../../activitypub'); const activitypub = require('../../activitypub');
const helpers = require('../helpers');
const Controller = module.exports; const Controller = module.exports;
@@ -117,6 +118,10 @@ Controller.postInbox = async (req, res) => {
return res.sendStatus(501); return res.sendStatus(501);
} }
await activitypub.inbox[method](req); try {
res.sendStatus(200); await activitypub.inbox[method](req);
helpers.formatApiResponse(200, res);
} catch (e) {
helpers.formatApiResponse(500, res, e);
}
}; };