Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: getUserField so that it always returns null

Browse Source 
if field doesn't exist
user.getUserField('foo', 'bar') returned undefined vs user.getUserField('1', 'bar') which returned null
This commit is contained in:
Barış Soner Uşaklı
2025-02-11 13:28:25 -05:00
parent d590c2afcf
commit e85662a536
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/user/data.js
View File

@@ -161,7 +161,7 @@ module.exports = function (User) {
User.getUserField = async function (uid, field) { User.getUserField = async function (uid, field) {
const user = await User.getUserFields(uid, [field]); const user = await User.getUserFields(uid, [field]);
return user ? user[field] : null; return user && user.hasOwnProperty(field) ? user[field] : null;
}; };
User.getUserFields = async function (uid, fields) { User.getUserFields = async function (uid, fields) {

6
test/user.js
View File

@@ -680,6 +680,12 @@ describe('User', () => {
done(); done();
}); });
}); });
it('should return null if field or user doesn not exist', async () => {
assert.strictEqual(await User.getUserField('1', 'doesnotexist'), null);
assert.strictEqual(await User.getUserField('doesnotexistkey', 'doesnotexist'), null);
assert.strictEqual(await User.getUserField('0', 'doesnotexist'), null);
});
}); });
describe('profile methods', () => { describe('profile methods', () => {