Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: rare crash if queued item is no longer in db but id is in post:queue

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2025-08-26 13:56:47 -04:00
parent 69a6c1502f
commit e79dfeb7c3
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/posts/queue.js
View File

@@ -24,7 +24,8 @@ module.exports = function (Posts) {
if (!postData) { if (!postData) {
const ids = await db.getSortedSetRange('post:queue', 0, -1); const ids = await db.getSortedSetRange('post:queue', 0, -1);
const keys = ids.map(id => `post:queue:${id}`); const keys = ids.map(id => `post:queue:${id}`);
postData = await db.getObjects(keys); postData = (await db.getObjects(keys)).filter(Boolean);
postData.forEach((data) => { postData.forEach((data) => {
if (data) { if (data) {
data.data = JSON.parse(data.data); data.data = JSON.parse(data.data);
@@ -50,7 +51,7 @@ module.exports = function (Posts) {
cache.set('post-queue', _.cloneDeep(postData)); cache.set('post-queue', _.cloneDeep(postData));
} }
if (filter.id) { if (filter.id) {
postData = postData.filter(p => p.id === filter.id); postData = postData.filter(p => p && p.id === filter.id);
} }
if (options.metadata) { if (options.metadata) {
await Promise.all(postData.map(addMetaData)); await Promise.all(postData.map(addMetaData));
@@ -59,11 +60,11 @@ module.exports = function (Posts) {
// Filter by tid if present // Filter by tid if present
if (filter.tid) { if (filter.tid) {
const tid = String(filter.tid); const tid = String(filter.tid);
postData = postData.filter(item => item.data.tid && String(item.data.tid) === tid); postData = postData.filter(item => item && item.data.tid && String(item.data.tid) === tid);
} else if (Array.isArray(filter.tid)) { } else if (Array.isArray(filter.tid)) {
const tids = filter.tid.map(String); const tids = filter.tid.map(String);
postData = postData.filter( postData = postData.filter(
item => item.data.tid && tids.includes(String(item.data.tid)) item => item && item.data.tid && tids.includes(String(item.data.tid))
); );
} }