Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: use apiv3 for room rename tests

Browse Source
This commit is contained in:
Julian Lam
2021-12-15 22:38:55 -05:00
parent 74f1905ea8
commit e745e21242
2 changed files with 10 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/messaging/rooms.js
View File

@@ -191,7 +191,7 @@ module.exports = function (Messaging) {
Messaging.renameRoom = async function (uid, roomId, newName) {
if (!newName) {
throw new Error('[[error:invalid-name]]');
throw new Error('[[error:invalid-data]]');
}
newName = newName.trim();
if (newName.length > 75) {

25
test/messaging.js
View File

@@ -521,24 +521,17 @@ describe('Messaging Library', () => {
});
});
it('should fail to rename room with invalid data', (done) => {
socketModules.chats.renameRoom({ uid: mocks.users.foo.uid }, null, (err) => {
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.renameRoom({ uid: mocks.users.foo.uid }, { roomId: null }, (err) => {
assert.equal(err.message, '[[error:invalid-data]]');
socketModules.chats.renameRoom({ uid: mocks.users.foo.uid }, { roomId: roomId, newName: null }, (err) => {
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
});
it('should fail to rename room with invalid data', async () => {
let { body } = await callv3API('put', `/chats/${roomId}`, { name: null }, 'foo');
assert.strictEqual(body.status.message, await translator.translate('[[error:invalid-data]]'));
({ body } = await callv3API('put', `/chats/${roomId}`, {}, 'foo'));
assert.strictEqual(body.status.message, await translator.translate('[[error:required-parameters-missing, name]]'));
});
it('should rename room', (done) => {
socketModules.chats.renameRoom({ uid: mocks.users.foo.uid }, { roomId: roomId, newName: 'new room name' }, (err) => {
assert.ifError(err);
done();
});
it('should rename room', async () => {
const { statusCode } = await callv3API('put', `/chats/${roomId}`, { name: 'new room name' }, 'foo');
assert.strictEqual(statusCode, 200);
});
it('should send a room-rename system message when a room is renamed', (done) => {