dont return undefined from sortedSetsCard if keys is empty or falsy

This commit is contained in:
Baris Usakli
2018-12-07 16:50:35 -05:00
parent 76af8caf58
commit e65d40c937
4 changed files with 21 additions and 3 deletions

View File

@@ -149,7 +149,7 @@ module.exports = function (db, module) {
module.sortedSetsCard = function (keys, callback) { module.sortedSetsCard = function (keys, callback) {
if (!Array.isArray(keys) || !keys.length) { if (!Array.isArray(keys) || !keys.length) {
return callback(); return callback(null, []);
} }
var pipeline = [ var pipeline = [
{ $match: { _key: { $in: keys } } }, { $match: { _key: { $in: keys } } },

View File

@@ -231,7 +231,7 @@ SELECT COUNT(*) c
module.sortedSetsCard = function (keys, callback) { module.sortedSetsCard = function (keys, callback) {
if (!Array.isArray(keys) || !keys.length) { if (!Array.isArray(keys) || !keys.length) {
return callback(); return callback(null, []);
} }
query({ query({

View File

@@ -116,7 +116,7 @@ module.exports = function (redisClient, module) {
}; };
module.sortedSetsCard = function (keys, callback) { module.sortedSetsCard = function (keys, callback) {
if (Array.isArray(keys) && !keys.length) { if (!Array.isArray(keys) || !keys.length) {
return callback(null, []); return callback(null, []);
} }
var batch = redisClient.batch(); var batch = redisClient.batch();

View File

@@ -331,6 +331,24 @@ describe('Sorted Set methods', function () {
done(); done();
}); });
}); });
it('should return empty array if keys is falsy', function (done) {
db.sortedSetsCard(undefined, function (err, counts) {
assert.ifError(err);
assert.equal(arguments.length, 2);
assert.deepEqual(counts, []);
done();
});
});
it('should return empty array if keys is empty array', function (done) {
db.sortedSetsCard([], function (err, counts) {
assert.ifError(err);
assert.equal(arguments.length, 2);
assert.deepEqual(counts, []);
done();
});
});
}); });
describe('sortedSetRank()', function () { describe('sortedSetRank()', function () {