refactor: dont expost entire res._locals to client side

public/src/app.js

@@ -353,7 +353,7 @@ app.flags = {};
 
 	function registerServiceWorker() {
 		// Do not register for Safari browsers
-		if (!ajaxify.data._locals.useragent.isSafari && 'serviceWorker' in navigator) {
+		if (!config.useragent.isSafari && 'serviceWorker' in navigator) {
 			navigator.serviceWorker.register(config.relative_path + '/service-worker.js', { scope: config.relative_path + '/' })
 				.then(function () {
 					console.info('ServiceWorker registration succeeded.');

src/controllers/api.js

@@ -81,6 +81,7 @@ apiController.loadConfig = async function (req) {
 		},
 		iconBackgrounds: await user.getIconBackgrounds(req.uid),
 		emailPrompt: meta.config.emailPrompt,
+		useragent: req.useragent,
 	};
 
 	let settings = config;

src/middleware/render.js

@@ -65,7 +65,7 @@ module.exports = function (middleware) {
 					req.app.set('json spaces', global.env === 'development' || req.query.pretty ? 4 : 0);
 					return res.json(options);
 				}
-
+				const optionsString = JSON.stringify(options).replace(/<\//g, '<\\/');
 				const results = await utils.promiseParallel({
 					header: renderHeaderFooter('renderHeader', req, res, options),
 					content: renderContent(render, templateToRender, req, res, options),
@@ -76,7 +76,7 @@ module.exports = function (middleware) {
 					(res.locals.postHeader || '') +
 					results.content
 				}<script id="ajaxify-data" type="application/json">${
-					JSON.stringify(options).replace(/<\//g, '<\\/')
+					optionsString
 				}</script>${
 					res.locals.preFooter || ''
 				}${results.footer}`;