Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-02 12:05:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: move groups.leave, fix some tests

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-10-15 17:29:38 -04:00
parent bbbd9fee85
commit e367c5403e
7 changed files with 106 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/groups.js
View File

@@ -1320,9 +1320,9 @@ describe('Groups', function () {
});
});
it('should fail to if user is already member', function (done) {
it('should not error if user is already member', function (done) {
socketGroups.join({ uid: adminUid }, { uid: testUid, groupName: 'newgroup' }, function (err) {
assert.equal(err.message, '[[error:group-already-member]]');
assert.ifError(err);
done();
});
});
@@ -1341,9 +1341,16 @@ describe('Groups', function () {
});
});
it('should fail if user is not member', function (done) {
it('should not error if user is not member', function (done) {
socketGroups.leave({ uid: adminUid }, { uid: 3, groupName: 'newgroup' }, function (err) {
assert.equal(err.message, '[[error:group-not-member]]');
assert.ifError(err);
done();
});
});
it('should fail if trying to remove someone else from group', function (done) {
socketGroups.leave({ uid: testUid }, { uid: adminUid, groupName: 'newgroup' }, function (err) {
assert.strictEqual(err.message, '[[error:no-privileges]]');
done();
});
});