Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-30 02:25:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: move groups.leave, fix some tests

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-10-15 17:29:38 -04:00
parent bbbd9fee85
commit e367c5403e
7 changed files with 106 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
src/controllers/write/groups.js
View File

@@ -1,12 +1,5 @@
'use strict';
const validator = require('validator');
const user = require('../../user');
const groups = require('../../groups');
const events = require('../../events');
const slugify = require('../../slugify');
const notifications = require('../../notifications');
const api = require('../../api');
const helpers = require('../helpers');
@@ -29,46 +22,6 @@ Groups.join = async (req, res) => {
};
Groups.leave = async (req, res) => {
const [group, userExists] = await Promise.all([
groups.getByGroupslug(req.params.slug, {
uid: req.params.uid,
}),
user.exists(req.params.uid),
]);
if (!userExists) {
throw new Error('[[error:invalid-uid]]');
} else if (group.disableLeave) {
throw new Error('[[error:group-leave-disabled]]');
} else if (!group.isMember) {
// No change
return helpers.formatApiResponse(200, res);
}
await groups.leave(group.name, req.params.uid);
// Notify owners of user having left
const username = await user.getUserField(req.params.uid, 'username');
const notification = await notifications.create({
type: 'group-leave',
bodyShort: '[[groups:membership.leave.notification_title, ' + username + ', ' + group.name + ']]',
nid: 'group:' + validator.escape(group.name) + ':uid:' + req.params.uid + ':group-leave',
path: '/groups/' + slugify(group.name),
});
const uids = await groups.getOwners(group.name);
await notifications.push(notification, uids);
await api.groups.leave(req, req.params);
helpers.formatApiResponse(200, res);
logGroupEvent(req, 'group-leave', {
groupName: group.name,
});
};
function logGroupEvent(req, event, additional) {
events.log({
type: event,
uid: req.user.uid,
ip: req.ip,
...additional,
});
}