Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 02:55:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #8918

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-11-25 14:33:19 -05:00
parent 3af4d13fa5
commit e32cd31ec6
3 changed files with 27 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/api/users.js
View File

@@ -82,15 +82,15 @@ usersAPI.update = async function (caller, data) {
}; };
usersAPI.delete = async function (caller, { uid, password }) { usersAPI.delete = async function (caller, { uid, password }) {
processDeletion({ uid: uid, method: 'delete', password, caller }); await processDeletion({ uid: uid, method: 'delete', password, caller });
}; };
usersAPI.deleteContent = async function (caller, { uid, password }) { usersAPI.deleteContent = async function (caller, { uid, password }) {
processDeletion({ uid, method: 'deleteContent', password, caller }); await processDeletion({ uid, method: 'deleteContent', password, caller });
}; };
usersAPI.deleteAccount = async function (caller, { uid, password }) { usersAPI.deleteAccount = async function (caller, { uid, password }) {
processDeletion({ uid, method: 'deleteAccount', password, caller }); await processDeletion({ uid, method: 'deleteAccount', password, caller });
}; };
usersAPI.deleteMany = async function (caller, data) { usersAPI.deleteMany = async function (caller, data) {

1
src/socket.io/user.js
View File

@@ -37,6 +37,7 @@ SocketUser.exists = async function (socket, data) {
SocketUser.deleteAccount = async function (socket, data) { SocketUser.deleteAccount = async function (socket, data) {
sockets.warnDeprecated(socket, 'DELETE /api/v3/users/:uid/account'); sockets.warnDeprecated(socket, 'DELETE /api/v3/users/:uid/account');
data.uid = socket.uid;
await api.users.deleteAccount(socket, data); await api.users.deleteAccount(socket, data);
}; };

29
test/user.js
View File

@@ -1593,18 +1593,29 @@ describe('User', function () {
}); });
}); });
it('should delete user', function (done) { it('should delete user', async function () {
User.create({ username: 'tobedeleted' }, function (err, _uid) { const uid = await User.create({ username: 'willbedeleted' });
assert.ifError(err); await socketUser.deleteAccount({ uid: uid }, {});
socketUser.deleteAccount({ uid: _uid }, {}, function (err) { const exists = await socketUser.exists({ uid: testUid }, { username: 'willbedeleted' });
assert.ifError(err);
socketUser.exists({ uid: testUid }, { username: 'doesnot exist' }, function (err, exists) {
assert.ifError(err);
assert(!exists); assert(!exists);
done();
});
}); });
it('should fail to delete user with wrong password', async function () {
const uid = await User.create({ username: 'willbedeletedpwd', password: '123456' });
let err;
try {
await socketUser.deleteAccount({ uid: uid }, { password: '654321' });
} catch (_err) {
err = _err;
}
assert.strictEqual(err.message, '[[error:invalid-password]]');
}); });
it('should delete user with correct password', async function () {
const uid = await User.create({ username: 'willbedeletedcorrectpwd', password: '123456' });
await socketUser.deleteAccount({ uid: uid }, { password: '123456' });
const exists = await User.exists(uid);
assert(!exists);
}); });
it('should fail to delete user if account deletion is not allowed', async function () { it('should fail to delete user if account deletion is not allowed', async function () {