socketio/posts socketio/topics refactor

This commit is contained in:
barisusakli
2015-09-25 15:09:25 -04:00
parent 04db07ed33
commit e2896ef6b9
13 changed files with 893 additions and 800 deletions

View File

@@ -1,27 +1,30 @@
"use strict";
var async = require('async'),
nconf = require('nconf'),
winston = require('winston'),
db = require('../database'),
posts = require('../posts'),
plugins = require('../plugins'),
privileges = require('../privileges'),
meta = require('../meta'),
topics = require('../topics'),
favourites = require('../favourites'),
notifications = require('../notifications'),
groups = require('../groups'),
user = require('../user'),
websockets = require('./index'),
socketTopics = require('./topics'),
events = require('../events'),
utils = require('../../public/src/utils'),
SocketPosts = {};
require('./posts/edit')(SocketPosts);
require('./posts/move')(SocketPosts);
require('./posts/favourites')(SocketPosts);
require('./posts/tools')(SocketPosts);
require('./posts/flag')(SocketPosts);
SocketPosts.reply = function(socket, data, callback) {
if(!data || !data.tid || !data.content) {
return callback(new Error('[[error:invalid-data]]'));
@@ -85,125 +88,6 @@ SocketPosts.notifyOnlineUsers = function(uid, result) {
});
};
SocketPosts.getVoters = function(socket, data, callback) {
if (!data || !data.pid || !data.cid) {
return callback(new Error('[[error:invalid-data]]'));
}
async.waterfall([
function (next) {
privileges.categories.isAdminOrMod(data.cid, socket.uid, next);
},
function (isAdminOrMod, next) {
if (!isAdminOrMod) {
return next(new Error('[[error:no-privileges]]'));
}
async.parallel({
upvoteUids: function(next) {
db.getSetMembers('pid:' + data.pid + ':upvote', next);
},
downvoteUids: function(next) {
db.getSetMembers('pid:' + data.pid + ':downvote', next);
}
}, next);
},
function (results, next) {
async.parallel({
upvoters: function(next) {
user.getMultipleUserFields(results.upvoteUids, ['username', 'userslug', 'picture'], next);
},
upvoteCount: function(next) {
next(null, results.upvoteUids.length);
},
downvoters: function(next) {
user.getMultipleUserFields(results.downvoteUids, ['username', 'userslug', 'picture'], next);
},
downvoteCount: function(next) {
next(null, results.downvoteUids.length);
}
}, next);
}
], callback);
};
SocketPosts.upvote = function(socket, data, callback) {
favouriteCommand(socket, 'upvote', 'voted', 'notifications:upvoted_your_post_in', data, callback);
};
SocketPosts.downvote = function(socket, data, callback) {
favouriteCommand(socket, 'downvote', 'voted', '', data, callback);
};
SocketPosts.unvote = function(socket, data, callback) {
favouriteCommand(socket, 'unvote', 'voted', '', data, callback);
};
SocketPosts.favourite = function(socket, data, callback) {
favouriteCommand(socket, 'favourite', 'favourited', 'notifications:favourited_your_post_in', data, callback);
};
SocketPosts.unfavourite = function(socket, data, callback) {
favouriteCommand(socket, 'unfavourite', 'favourited', '', data, callback);
};
function favouriteCommand(socket, command, eventName, notification, data, callback) {
if(!data || !data.pid || !data.room_id) {
return callback(new Error('[[error:invalid-data]]'));
}
async.parallel({
exists: function(next) {
posts.exists(data.pid, next);
},
deleted: function(next) {
posts.getPostField(data.pid, 'deleted', next);
}
}, function(err, results) {
if (err || !results.exists) {
return callback(err || new Error('[[error:invalid-pid]]'));
}
if (parseInt(results.deleted, 10) === 1) {
return callback(new Error('[[error:post-deleted]]'));
}
/*
hooks:
filter.post.upvote
filter.post.downvote
filter.post.unvote
filter.post.favourite
filter.post.unfavourite
*/
plugins.fireHook('filter:post.' + command, {data: data, uid: socket.uid}, function(err, filteredData) {
if (err) {
return callback(err);
}
executeFavouriteCommand(socket, command, eventName, notification, filteredData.data, callback);
});
});
}
function executeFavouriteCommand(socket, command, eventName, notification, data, callback) {
favourites[command](data.pid, socket.uid, function(err, result) {
if (err) {
return callback(err);
}
socket.emit('posts.' + command, result);
if (result && eventName) {
websockets.in(data.room_id).emit('event:' + eventName, result);
}
if (notification) {
SocketPosts.sendNotificationToPostOwner(data.pid, socket.uid, notification);
}
callback();
});
}
SocketPosts.sendNotificationToPostOwner = function(pid, fromuid, notification) {
if(!pid || !fromuid || !notification) {
return;
@@ -261,165 +145,6 @@ SocketPosts.getRawPost = function(socket, pid, callback) {
], callback);
};
SocketPosts.edit = function(socket, data, callback) {
if (!socket.uid) {
return callback(new Error('[[error:not-logged-in]]'));
} else if (!data || !data.pid || !data.content) {
return callback(new Error('[[error:invalid-data]]'));
} else if (data.title && data.title.length < parseInt(meta.config.minimumTitleLength, 10)) {
return callback(new Error('[[error:title-too-short, ' + meta.config.minimumTitleLength + ']]'));
} else if (data.title && data.title.length > parseInt(meta.config.maximumTitleLength, 10)) {
return callback(new Error('[[error:title-too-long, ' + meta.config.maximumTitleLength + ']]'));
} else if (data.tags && data.tags.length < parseInt(meta.config.minimumTagsPerTopic, 10)) {
return callback(new Error('[[error:not-enough-tags, ' + meta.config.minimumTagsPerTopic + ']]'));
} else if (data.tags && data.tags.length > parseInt(meta.config.maximumTagsPerTopic, 10)) {
return callback(new Error('[[error:too-many-tags, ' + meta.config.maximumTagsPerTopic + ']]'));
} else if (!data.content || data.content.length < parseInt(meta.config.minimumPostLength, 10)) {
return callback(new Error('[[error:content-too-short, ' + meta.config.minimumPostLength + ']]'));
} else if (data.content.length > parseInt(meta.config.maximumPostLength, 10)) {
return callback(new Error('[[error:content-too-long, ' + meta.config.maximumPostLength + ']]'));
}
posts.edit({
uid: socket.uid,
handle: data.handle,
pid: data.pid,
title: data.title,
content: data.content,
topic_thumb: data.topic_thumb,
tags: data.tags
}, function(err, result) {
if (err) {
return callback(err);
}
if (result.topic.renamed) {
events.log({
type: 'topic-rename',
uid: socket.uid,
ip: socket.ip,
oldTitle: result.topic.oldTitle,
newTitle: result.topic.title
});
}
if (parseInt(result.post.deleted) !== 1) {
websockets.in('topic_' + result.topic.tid).emit('event:post_edited', result);
return callback(null, result.post);
}
socket.emit('event:post_edited', result);
callback(null, result.post);
async.parallel({
admins: async.apply(groups.getMembers, 'administrators', 0, -1),
moderators: async.apply(groups.getMembers, 'cid:' + result.topic.cid + ':privileges:mods', 0, -1),
uidsInTopic: async.apply(websockets.getUidsInRoom, 'topic_' + result.topic.tid)
}, function(err, results) {
if (err) {
return winston.error(err);
}
var uids = results.uidsInTopic.filter(function(uid) {
return results.admins.indexOf(uid) !== -1 || results.moderators.indexOf(uid) !== -1;
});
uids.forEach(function(uid) {
websockets.in('uid_' + uid).emit('event:post_edited', result);
});
});
});
};
SocketPosts.delete = function(socket, data, callback) {
doPostAction('delete', 'event:post_deleted', socket, data, callback);
};
SocketPosts.restore = function(socket, data, callback) {
doPostAction('restore', 'event:post_restored', socket, data, callback);
};
function doPostAction(command, eventName, socket, data, callback) {
if (!data) {
return callback(new Error('[[error:invalid-data]]'));
}
posts.tools[command](socket.uid, data.pid, function(err, postData) {
if (err) {
return callback(err);
}
websockets.in('topic_' + data.tid).emit(eventName, postData);
events.log({
type: 'post-' + command,
uid: socket.uid,
pid: data.pid,
ip: socket.ip
});
callback();
});
}
SocketPosts.purge = function(socket, data, callback) {
function purgePost() {
posts.tools.purge(socket.uid, data.pid, function(err) {
if (err) {
return callback(err);
}
websockets.in('topic_' + data.tid).emit('event:post_purged', data.pid);
events.log({
type: 'post-purge',
uid: socket.uid,
pid: data.pid,
ip: socket.ip
});
callback();
});
}
if (!data || !parseInt(data.pid, 10)) {
return callback(new Error('[[error:invalid-data]]'));
}
isMainAndLastPost(data.pid, function(err, results) {
if (err) {
return callback(err);
}
if (!results.isMain) {
return purgePost();
}
if (!results.isLast) {
return callback(new Error('[[error:cant-purge-main-post]]'));
}
posts.getTopicFields(data.pid, ['tid', 'cid'], function(err, topic) {
if (err) {
return callback(err);
}
socketTopics.doTopicAction('delete', 'event:topic_deleted', socket, {tids: [topic.tid], cid: topic.cid}, callback);
});
});
};
function isMainAndLastPost(pid, callback) {
async.parallel({
isMain: function(next) {
posts.isMain(pid, next);
},
isLast: function(next) {
posts.getTopicFields(pid, ['postcount'], function(err, topic) {
next(err, topic ? parseInt(topic.postcount, 10) === 1 : false);
});
}
}, callback);
}
SocketPosts.getPrivileges = function(socket, pids, callback) {
privileges.posts.get(pids, socket.uid, function(err, privileges) {
@@ -434,112 +159,6 @@ SocketPosts.getPrivileges = function(socket, pids, callback) {
});
};
SocketPosts.getUpvoters = function(socket, pids, callback) {
if (!Array.isArray(pids)) {
return callback(new Error('[[error:invalid-data]]'));
}
favourites.getUpvotedUidsByPids(pids, function(err, data) {
if (err || !Array.isArray(data) || !data.length) {
return callback(err, []);
}
async.map(data, function(uids, next) {
var otherCount = 0;
if (uids.length > 6) {
otherCount = uids.length - 5;
uids = uids.slice(0, 5);
}
user.getUsernamesByUids(uids, function(err, usernames) {
next(err, {
otherCount: otherCount,
usernames: usernames
});
});
}, callback);
});
};
SocketPosts.flag = function(socket, pid, callback) {
if (!socket.uid) {
return callback(new Error('[[error:not-logged-in]]'));
}
var message = '',
flaggingUser = {},
post;
async.waterfall([
function(next) {
posts.getPostFields(pid, ['pid', 'tid', 'uid', 'content', 'deleted'], function(err, postData) {
if (parseInt(postData.deleted, 10) === 1) {
return next(new Error('[[error:post-deleted]]'));
}
post = postData;
next();
});
},
function(next) {
topics.getTopicFields(post.tid, ['title', 'cid'], function(err, topicData) {
post.topic = topicData;
next();
});
},
function(next) {
async.parallel({
isAdminOrMod: function(next) {
privileges.categories.isAdminOrMod(post.topic.cid, next);
},
userData: function(next) {
user.getUserFields(socket.uid, ['username', 'reputation'], next);
}
}, next);
},
function(user, next) {
if (!user.isAdminOrMod && parseInt(user.userData.reputation, 10) < parseInt(meta.config['privileges:flag'] || 1, 10)) {
return next(new Error('[[error:not-enough-reputation-to-flag]]'));
}
flaggingUser = user.userData;
flaggingUser.uid = socket.uid;
next();
},
function(next) {
posts.flag(post, socket.uid, next);
},
function(next) {
message = '[[notifications:user_flagged_post_in, ' + flaggingUser.username + ', ' + post.topic.title + ']]';
posts.parsePost(post, next);
},
function(post, next) {
async.parallel({
admins: function(next) {
groups.getMembers('administrators', 0, -1, next);
},
moderators: function(next) {
groups.getMembers('cid:' + post.topic.cid + ':privileges:mods', 0, -1, next);
}
}, next);
},
function(results, next) {
notifications.create({
bodyShort: message,
bodyLong: post.content,
pid: pid,
nid: 'post_flag:' + pid + ':uid:' + socket.uid,
from: socket.uid
}, function(err, notification) {
if (err || !notification) {
return next(err);
}
plugins.fireHook('action:post.flag', {post: post, flaggingUser: flaggingUser});
notifications.push(notification, results.admins.concat(results.moderators), next);
});
}
], callback);
};
SocketPosts.loadMoreFavourites = function(socket, data, callback) {
loadMorePosts('uid:' + data.uid + ':favourites', socket.uid, data, callback);
@@ -560,14 +179,6 @@ function loadMorePosts(set, uid, data, callback) {
posts.getPostSummariesFromSet(set, uid, start, stop, callback);
}
SocketPosts.getRecentPosts = function(socket, data, callback) {
if (!data || !data.count) {
return callback(new Error('[[error:invalid-data]]'));
}
posts.getRecentPosts(socket.uid, 0, data.count - 1, data.term, callback);
};
SocketPosts.getCategory = function(socket, pid, callback) {
posts.getCidByPid(pid, callback);
};