Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: unable to register async method as response hook listener

Browse Source 
Also fixes #8723, /api/config now runs middleware.authenticateOrGuest
This commit is contained in:
Julian Lam
2020-10-06 09:32:05 -04:00
parent b01bc2ae0f
commit dde5b6b814
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/hooks.js
View File

@@ -189,21 +189,20 @@ module.exports = function (Plugins) {
if (!Array.isArray(hookList) || !hookList.length) {
return;
}
await async.eachSeries(hookList, function (hookObj, next) {
await async.eachSeries(hookList, async (hookObj) => {
if (typeof hookObj.method !== 'function') {
if (global.env === 'development') {
winston.warn('[plugins] Expected method for hook \'' + hook + '\' in plugin \'' + hookObj.id + '\' not found, skipping.');
}
return next();
return;
}
// Skip remaining hooks if headers have been sent
if (params.res.headersSent) {
return next();
return;
}
hookObj.method(params);
next();
await hookObj.method(params);
});
}