Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: update error handler to check for pseudo-standard no-* prefix and route to 404 handler instead

Browse Source
This commit is contained in:
Julian Lam
2023-10-11 13:37:35 -04:00
parent e012edea3b
commit db5b0f47e0
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/controllers/errors.js
View File

@@ -48,6 +48,12 @@ exports.handleErrors = async function handleErrors(err, req, res, next) { // esl
res.status(403).type('text/plain').send(err.message); res.status(403).type('text/plain').send(err.message);
}, },
}; };
const notFoundHandler = () => {
const controllers = require('.');
controllers['404'].handle404(req, res);
};
const defaultHandler = async function () { const defaultHandler = async function () {
if (res.headersSent) { if (res.headersSent) {
return; return;
@@ -87,6 +93,8 @@ exports.handleErrors = async function handleErrors(err, req, res, next) { // esl
try { try {
if (data.cases.hasOwnProperty(err.code)) { if (data.cases.hasOwnProperty(err.code)) {
data.cases[err.code](err, req, res, defaultHandler); data.cases[err.code](err, req, res, defaultHandler);
} else if (err.message.startsWith('[[error:no-') && err.message !== '[[error:no-privileges]]') {
notFoundHandler();
} else { } else {
await defaultHandler(); await defaultHandler();
} }