Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #6921, allow square brackets in usernames

Browse Source
This commit is contained in:
Julian Lam
2018-11-07 16:01:22 -05:00
parent 64b9dabff8
commit da10ca084b
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
public/src/utils.js
View File

@@ -321,7 +321,7 @@
if (typeof target === 'number') {
return String.fromCharCode(target);
} else if (typeof target === 'string') {
} if (typeof target === 'string') {
return target;
}
@@ -391,7 +391,7 @@
},
isUserNameValid: function (name) {
return (name && name !== '' && (/^['"\s\-+.*0-9\u00BF-\u1FFF\u2C00-\uD7FF\w]+$/.test(name)));
return (name && name !== '' && (/^['"\s\-+.*[\]0-9\u00BF-\u1FFF\u2C00-\uD7FF\w]+$/.test(name)));
},
isPasswordValid: function (password) {
@@ -487,7 +487,7 @@
}
if (n > 999999) {
return (n / 1000000).toFixed(1) + 'm';
} else if (n > 999) {
} if (n > 999) {
return (n / 1000).toFixed(1) + 'k';
}
return n;

6
test/utils.js
View File

@@ -51,10 +51,16 @@ describe('Utility Methods', function () {
var username = "John\"'-. Doeäâèéë1234";
assert(utils.isUserNameValid(username), 'invalid username');
});
it('rejects empty string', function () {
var username = '';
assert.equal(utils.isUserNameValid(username), false, 'accepted as valid username');
});
it('accepts square brackets', function () {
var username = '[best clan] julian';
assert(utils.isUserNameValid(username), 'invalid username');
});
});
describe('email validation', function () {