Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-08 06:55:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

remove async dep for widgets (30kb was overkill for one use of async.each); linting

Browse Source
This commit is contained in:
psychobunny
2014-03-12 15:05:07 -04:00
parent dc99701d42
commit da0355ef79
2 changed files with 42 additions and 990 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
public/src/ajaxify.js
View File

@@ -3,7 +3,7 @@
var ajaxify = {};
(function () {
/*global app, templates, utils*/
/*global app, templates, utils, socket, translator, config, RELATIVE_PATH*/
var location = document.location || window.location,
rootUrl = location.protocol + '//' + (location.hostname || location.host) + (location.port ? ':' + location.port : ''),
@@ -129,7 +129,7 @@ var ajaxify = {};
ajaxify.getTemplateMapping = function(url) {
var tpl_url = templates.get_custom_map(url.split('?')[0]);
if (tpl_url == false && !templates[url]) {
if (tpl_url === false && !templates[url]) {
if (url === '' || url === '/') {
tpl_url = 'home';
} else if (url === 'admin' || url === 'admin/') {
@@ -154,40 +154,50 @@ var ajaxify = {};
}
return tpl_url;
}
};
ajaxify.renderWidgets = function(tpl_url, url, callback) {
var widgetLocations = [];
var widgetLocations = [], numLocations;
require(['vendor/async'], function(async) {
$('#content [widget-area]').each(function() {
widgetLocations.push($(this).attr('widget-area'));
});
async.each(widgetLocations, function(location, next) {
var area = $('#content [widget-area="' + location + '"]');
socket.emit('widgets.render', {template: tpl_url + '.tpl', url: url, location: location}, function(err, renderedWidgets) {
area.html(templates.prepare(area.html()).parse({
widgets: renderedWidgets
})).removeClass('hidden');
if (!renderedWidgets.length) {
$('body [no-widget-class]').each(function() {
var $this = $(this);
$this.removeClass();
$this.addClass($this.attr('no-widget-class'));
});
}
next(err);
});
}, function(err) {
if (callback) {
callback(err);
}
});
$('#content [widget-area]').each(function() {
widgetLocations.push($(this).attr('widget-area'));
});
numLocations = widgetLocations.length;
function renderWidget(err, renderedWidgets) {
area.html(templates.prepare(area.html()).parse({
widgets: renderedWidgets
})).removeClass('hidden');
if (!renderedWidgets.length) {
$('body [no-widget-class]').each(function() {
var $this = $(this);
$this.removeClass();
$this.addClass($this.attr('no-widget-class'));
});
}
checkCallback();
}
function checkCallback() {
numLocations--;
if (numLocations <= 0 && callback) {
callback();
}
}
for (var i in widgetLocations) {
if (widgetLocations.hasOwnProperty(i)) {
var location = widgetLocations,
area = $('#content [widget-area="' + location + '"]');
socket.emit('widgets.render', {template: tpl_url + '.tpl', url: url, location: location}, renderWidget);
}
}
checkCallback();
};