Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-27 09:06:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: error handling with POST /api/v1/users

Browse Source
This commit is contained in:
Julian Lam
2020-03-30 11:05:01 -04:00
parent 58043e07ba
commit d8879d21db
3 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
public/src/admin/manage/users.js
View File

@@ -359,9 +359,8 @@ define('admin/manage/users', ['translator', 'benchpress', 'autocomplete'], funct
ajaxify.refresh(); ajaxify.refresh();
}); });
app.alertSuccess('[[admin/manage/users:alerts.create-success]]'); app.alertSuccess('[[admin/manage/users:alerts.create-success]]');
}).fail(function () { }).fail(function (ev) {
console.log(arguments); return errorEl.translateHtml('[[admin/manage/users:alerts.error-x, ' + ev.responseJSON.status.message + ']]').removeClass('d-none').addClass('d-block');
// return errorEl.translateHtml('[[admin/manage/users:alerts.error-x, ' + err.message + ']]').removeClass('hide');
}); });
} }

4
src/routes/write/users.js
View File

@@ -16,8 +16,12 @@ module.exports = function () {
var app = require('express').Router(); var app = require('express').Router();
app.post('/', middleware.checkRequired.bind(null, ['username']), middleware.authenticate, middleware.isAdmin, async (req, res) => { app.post('/', middleware.checkRequired.bind(null, ['username']), middleware.authenticate, middleware.isAdmin, async (req, res) => {
try {
const uid = await users.create(req.body); const uid = await users.create(req.body);
helpers.formatApiResponse(200, res, await users.getUserData(uid)); helpers.formatApiResponse(200, res, await users.getUserData(uid));
} catch (err) {
helpers.formatApiResponse(400, res, err);
}
}); });
// app.route('/:uid') // app.route('/:uid')

2
src/views/admin/partials/create_user_modal.tpl
View File

@@ -1,4 +1,4 @@
<div class="alert alert-danger hide" id="create-modal-error"></div> <div class="alert alert-danger d-none" id="create-modal-error"></div>
<form> <form>
<div class="form-group"> <div class="form-group">
<label for="group-name">[[admin/manage/users:create.username]]</label> <label for="group-name">[[admin/manage/users:create.username]]</label>