Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-30 02:25:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: move groups.join to api

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-10-15 16:13:19 -04:00
parent eed8deda61
commit d69e503d21
4 changed files with 60 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/controllers/write/groups.js
View File

@@ -5,7 +5,6 @@ const validator = require('validator');
const user = require('../../user');
const groups = require('../../groups');
const events = require('../../events');
const meta = require('../../meta');
const slugify = require('../../slugify');
const notifications = require('../../notifications');
const api = require('../../api');
@@ -40,40 +39,8 @@ Groups.delete = async (req, res) => {
};
Groups.join = async (req, res) => {
const group = await groups.getByGroupslug(req.params.slug, {
uid: req.params.uid,
});
const [isCallerOwner, userExists] = await Promise.all([
groups.ownership.isOwner(req.user.uid, group.name),
user.exists(req.params.uid),
]);
if (!userExists) {
throw new Error('[[error:invalid-uid]]');
} else if (group.isMember) {
// No change
return helpers.formatApiResponse(200, res);
}
if (!res.locals.privileges.isAdmin) {
// Admin and privilege groups unjoinable client-side
if (groups.systemGroups.includes(group.name) || groups.isPrivilegeGroup(group.name)) {
throw new Error('[[error:not-allowed]]');
}
if (!isCallerOwner && parseInt(meta.config.allowPrivateGroups, 10) !== 0 && group.private) {
await groups.requestMembership(group.name, req.params.uid);
} else {
await groups.join(group.name, req.params.uid);
}
} else {
await groups.join(group.name, req.params.uid);
}
await api.groups.join(req, req.params);
helpers.formatApiResponse(200, res);
logGroupEvent(req, 'group-join', {
groupName: group.name,
});
};
Groups.leave = async (req, res) => {