Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-08 23:15:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

changing renderHeader function signature to req, res, next

Browse Source
This commit is contained in:
psychobunny
2014-03-03 16:54:28 -05:00
parent 48b9289002
commit d3aead7c13
3 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/controllers/admin.js
View File

@@ -157,7 +157,7 @@ adminController.database.get = function(req, res, next) {
}); });
}; };
// todo: deprecate this seemingly useless view
adminController.topics.get = function(req, res, next) { adminController.topics.get = function(req, res, next) {
topics.getAllTopics(0, 19, function (err, topics) { topics.getAllTopics(0, 19, function (err, topics) {
var data = { var data = {

2
src/middleware/admin.js
View File

@@ -70,8 +70,6 @@ middleware.buildHeader = function(req, res, next) {
}); });
}; };
module.exports = function(webserver) { module.exports = function(webserver) {
app = webserver; app = webserver;
return middleware; return middleware;

12
src/middleware/middleware.js
View File

@@ -129,12 +129,7 @@ middleware.buildHeader = function(req, res, next) {
}); });
}; };
/** middleware.renderHeader = function(req, res, callback) {
* TODO: switch signature to req, res, callback
* `options` object requires: req, res
* accepts: metaTags, linkTags
*/
middleware.renderHeader = function (options, callback) {
var custom_header = { var custom_header = {
'navigation': [] 'navigation': []
}; };
@@ -284,10 +279,7 @@ middleware.processRender = function(req, res, next) {
} }
if (res.locals.renderHeader) { if (res.locals.renderHeader) {
middleware.renderHeader({ middleware.renderHeader(req, res, function(err, template) {
req: req,
res: res
}, function(err, template) {
str = template + str; str = template + str;
translator.translate(str, function(translated) { translator.translate(str, function(translated) {