Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: allowing forward slash in language keys, temporarily allowing upper case characters

Browse Source
This commit is contained in:
Julian Lam
2023-10-06 11:29:35 -04:00
parent 15a0a19602
commit d25a24fcf4
1 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
test/i18n.js
View File

@@ -38,7 +38,7 @@ describe('i18n', () => {
const sourceStrings = new Map(); const sourceStrings = new Map();
describe('source language file structure', () => { describe('source language file structure', () => {
const test = /^[0-9a-z.-]+$/; const test = /^[0-9\w.\-/]+$/;
it('should only contain valid JSON files', async () => { it('should only contain valid JSON files', async () => {
try { try {
@@ -55,7 +55,7 @@ describe('i18n', () => {
} }
}); });
it('should only contain lowercase or numeric language keys separated by either dashes or periods', async () => { describe('should only contain lowercase or numeric language keys separated by either dashes or periods', async () => {
fullPaths.forEach((fullPath) => { fullPaths.forEach((fullPath) => {
if (fullPath.endsWith('_DO_NOT_EDIT_FILES_HERE.md')) { if (fullPath.endsWith('_DO_NOT_EDIT_FILES_HERE.md')) {
return; return;
@@ -64,17 +64,21 @@ describe('i18n', () => {
const hash = require(fullPath); const hash = require(fullPath);
const keys = Object.keys(hash); const keys = Object.keys(hash);
keys.forEach(key => assert(test.test(key), `${key} contains invalid characters`)); keys.forEach((key) => {
it(key, () => {
assert(test.test(key), `${key} contains invalid characters`);
});
});
}); });
}); });
it('regexp used in test should test according to expectations', () => { // it('regexp used in test should test according to expectations', () => {
const valid = ['foo.bar', 'foo.bar-baz', 'foo.bar.baz-quux-lorem-ipsum-dolor-sit-amet']; // const valid = ['foo.bar', 'foo.bar-baz', 'foo.bar.baz-quux-lorem-ipsum-dolor-sit-amet'];
const invalid = ['camelCase', 'PascalCase', 'snake_case', 'badger.badger_badger_badger', 'snnnaaaaaaAAAAAAkeeee']; // const invalid = ['camelCase', 'PascalCase', 'snake_case', 'badger.badger_badger_badger', 'snnnaaaaaaAAAAAAkeeee'];
assert(valid.every(key => test.test(key))); // assert(valid.every(key => test.test(key)));
assert(!invalid.every(key => test.test(key))); // assert(!invalid.every(key => test.test(key)));
}); // });
}); });
folders.forEach((language) => { folders.forEach((language) => {