Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-12 08:55:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

removing use of slugs in groups... pending having more time

Browse Source
This commit is contained in:
Julian Lam
2014-04-09 14:46:18 -04:00
parent bd2a1a3efa
commit d1a64798b9
2 changed files with 1 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/groups.js
View File

@@ -83,7 +83,6 @@
results.base.members = results.users;
results.base.memberCount = numUsers || results.users.length;
results.base.slug = utils.slugify(results.base.name);
results.base.deleted = !!parseInt(results.base.deleted, 10);
results.base.hidden = !!parseInt(results.base.hidden, 10);
results.base.system = !!parseInt(results.base.system, 10);
@@ -133,20 +132,7 @@
};
Groups.exists = function(name, callback) {
name = utils.slugify(name);
db.getSetMembers('groups', function(err, groupNames) {
if (err) {
return callback(err);
}
var matches = groupNames.map(function(groupName) {
return utils.slugify(groupName);
}).filter(function(groupName) {
return groupName === name;
});
callback(null, matches.length > 0 ? true : false);
});
db.isSetMember('groups', name, callback);
};
Groups.create = function(name, description, callback) {

18
tests/groups.js
View File

@@ -71,15 +71,6 @@ describe('Groups', function() {
done();
});
});
it('should auto-generate a slug given the group name', function(done) {
Groups.get('Test', {}, function(err, groupObj) {
if (err) return done(err);
assert.strictEqual('test', groupObj.slug);
done();
});
});
});
describe('.search()', function() {
@@ -166,15 +157,6 @@ describe('Groups', function() {
done();
});
});
it('should properly resolve a non-slugified group to slugs', function(done) {
Groups.exists('Test();', function(err, exists) {
if (err) return done(err);
assert.strictEqual(exists, true);
done();
});
});
});
describe('.create()', function() {