Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: use fewer system resources to draw the progress bar

Browse Source 
There's reason to believe that upgrade scripts will run faster
if the system isn't spending a non-insignificant amount of
resources simply drawing the progress bar. Closes #7711

Some context: https://github.com/npm/npm/issues/11283
This commit is contained in:
Julian Lam
2019-06-25 14:55:27 -04:00
parent f0703e21c5
commit d0ee312cd3
1 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/upgrade.js
View File

@@ -204,16 +204,18 @@ Upgrade.process = function (files, skipCount, callback) {
Upgrade.incrementProgress = function (value) { Upgrade.incrementProgress = function (value) {
this.current += value || 1; this.current += value || 1;
// Redraw the progress bar // Redraw the progress bar every 100 units
var percentage = 0; if (this.current % 100 === 0) {
var filled = 0; var percentage = 0;
var unfilled = 15; var filled = 0;
if (this.total) { var unfilled = 15;
percentage = Math.floor((this.current / this.total) * 100) + '%'; if (this.total) {
filled = Math.floor((this.current / this.total) * 15); percentage = Math.floor((this.current / this.total) * 100) + '%';
unfilled = Math.max(0, 15 - filled); filled = Math.floor((this.current / this.total) * 15);
} unfilled = Math.max(0, 15 - filled);
}
readline.cursorTo(process.stdout, 0); readline.cursorTo(process.stdout, 0);
process.stdout.write(' [' + (filled ? new Array(filled).join('#') : '') + new Array(unfilled).join(' ') + '] (' + this.current + '/' + (this.total || '??') + ') ' + percentage + ' '); process.stdout.write(' [' + (filled ? new Array(filled).join('#') : '') + new Array(unfilled).join(' ') + '] (' + this.current + '/' + (this.total || '??') + ') ' + percentage + ' ');
}
}; };