Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: update note assertion topic members check to simpler posts.exists check

Browse Source 
The original logic checked that each member of the resolved chain was part of the resolved topic.

That isn't always the case, especially when topics splinter due to network timeouts/unavailability.

This ended up causing issues where already asserted posts were re-asserted but failed because they no longer served an _activitypub object since it was already asserted and the data was just pulled from the db.
This commit is contained in:
Julian Lam
2025-09-22 12:14:14 -04:00
parent 4d68e3fe14
commit d0c058263f
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/activitypub/notes.js
View File

@@ -117,9 +117,8 @@ Notes.assert = async (uid, input, options = { skipChecks: false }) => {
await topics.tools.move(tid, { cid: options.cid, uid: 'system' });
}
const members = await db.isSortedSetMembers(`tid:${tid}:posts`, chain.slice(1).map(p => p.pid));
members.unshift(await posts.exists(mainPid));
if (tid && members.every(Boolean)) {
const exists = await posts.exists(chain.map(p => p.pid));
if (tid && exists.every(Boolean)) {
// All cached, return early.
activitypub.helpers.log('[notes/assert] No new notes to process.');
await unlock(id);
@@ -212,7 +211,7 @@ Notes.assert = async (uid, input, options = { skipChecks: false }) => {
}
return post;
}).filter((p, idx) => !members[idx]);
}).filter((p, idx) => !exists[idx]);
const count = unprocessed.length;
activitypub.helpers.log(`[notes/assert] ${count} new note(s) found.`);