Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 19:15:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: pinned topic ordering if parent element has non topic elements

Browse Source 
for example
<ul component="category" class="topic-list" itemscope itemtype="http://www.schema.org/ItemList" data-nextstart="{nextStart}" data-set="{set}">
	<meta itemprop="itemListOrder" content="descending">
	{{{each topics}}}
	<!-- IMPORT partials/topics_list_item.tpl -->
	{{{ end }}}
</ul>
This commit is contained in:
Barış Soner Uşaklı
2023-06-21 09:54:00 -04:00
parent e0c137c912
commit cfedd0877f
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
public/src/client/category/tools.js
View File

@@ -314,14 +314,24 @@ define('forum/category/tools', [
baseIndex = parseInt(topicListEl.find('[component="category/topic"].pinned').first().attr('data-index'), 10); baseIndex = parseInt(topicListEl.find('[component="category/topic"].pinned').first().attr('data-index'), 10);
}, },
update: function (ev, ui) { update: function (ev, ui) {
const tid = ui.item.attr('data-tid');
const pinnedTopicEls = topicListEl.find('[component="category/topic"].pinned');
let newIndex = 0;
pinnedTopicEls.each((index, el) => {
if ($(el).attr('data-tid') === tid) {
newIndex = index;
return false;
}
});
socket.emit('topics.orderPinnedTopics', { socket.emit('topics.orderPinnedTopics', {
tid: ui.item.attr('data-tid'), tid: tid,
order: baseIndex + ui.item.index(), order: baseIndex + newIndex,
}, function (err) { }, function (err) {
if (err) { if (err) {
return alerts.error(err); return alerts.error(err);
} }
topicListEl.find('[component="category/topic"].pinned').each((index, el) => { pinnedTopicEls.each((index, el) => {
$(el).attr('data-index', baseIndex + index); $(el).attr('data-index', baseIndex + index);
}); });
}); });