Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-30 10:35:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: handle undo(Announce) of remote notes

Browse Source
This commit is contained in:
Julian Lam
2024-02-20 13:43:45 -05:00
parent d77de088e6
commit cfbbf4ca86
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/activitypub/inbox.js
View File

@@ -229,9 +229,9 @@ inbox.undo = async (req) => {
throw new Error('[[error:activitypub.invalid-id]]'); throw new Error('[[error:activitypub.invalid-id]]');
} }
const { type: localType, id } = await helpers.resolveLocalId(object.object); let { type: localType, id } = await helpers.resolveLocalId(object.object);
winston.info(`[activitypub/inbox/undo] ${type} ${localType} ${id} via ${actor}`); winston.info(`[activitypub/inbox/undo] ${type} ${localType && id ? `${localType} ${id}` : object.object} via ${actor}`);
switch (type) { switch (type) {
case 'Follow': { case 'Follow': {
@@ -273,9 +273,10 @@ inbox.undo = async (req) => {
} }
case 'Announce': { case 'Announce': {
id = id || object.object; // remote announces
const exists = await posts.exists(id); const exists = await posts.exists(id);
if (localType !== 'post' || !exists) { if (!exists) {
throw new Error('[[error:invalid-pid]]'); winston.verbose(`[activitypub/inbox/undo] Attempted to undo announce of ${id} but couldn't find it, so doing nothing.`);
} }
const tid = await posts.getPostField(id, 'tid'); const tid = await posts.getPostField(id, 'tid');