Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-12-20 23:40:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: no more session cookie for guests (#7982)

Browse Source 
* feat: no more session cookie for guests

* fix(tests): added additional tests and fixed the broken test
This commit is contained in:
Julian Lam
2019-10-22 13:38:36 -04:00
committed by GitHub
parent 6155c4600f
commit cf7e0cfd2d
5 changed files with 43 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
test/controllers.js
View File

@@ -1398,20 +1398,51 @@ describe('Controllers', function () {
});
});
it('should increase profile view', function (done) {
it('should not increase profile view if you visit your own profile', (done) => {
request(nconf.get('url') + '/api/user/foo', { jar: jar }, function (err, res) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
setTimeout(function () {
user.getUserField(fooUid, 'profileviews', function (err, viewcount) {
assert.ifError(err);
assert(viewcount === 0);
done();
});
}, 500);
});
});
it('should not increase profile view if a guest visits a profile', (done) => {
request(nconf.get('url') + '/api/user/foo', { }, function (err, res) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
setTimeout(function () {
user.getUserField(fooUid, 'profileviews', function (err, viewcount) {
assert.ifError(err);
assert(viewcount > 0);
assert(viewcount === 0);
done();
});
}, 500);
});
});
it('should increase profile view', function (done) {
helpers.loginUser('regularJoe', 'barbar', function (err, jar) {
assert.ifError(err);
request(nconf.get('url') + '/api/user/foo', { jar: jar }, function (err, res) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
setTimeout(function () {
user.getUserField(fooUid, 'profileviews', function (err, viewcount) {
assert.ifError(err);
assert(viewcount > 0);
done();
});
}, 500);
});
});
});
it('should parse about me', function (done) {
user.setUserFields(fooUid, { picture: '/path/to/picture', aboutme: 'hi i am a bot' }, function (err) {
assert.ifError(err);