Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-06 05:55:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

test: added tests for new logic paths (toPid validation on post creation)

Browse Source 
re: #12025
This commit is contained in:
Julian Lam
2023-09-22 16:50:29 -04:00
parent fe42fd4ebc
commit ce7403014a
1 changed files with 46 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
test/topics.js
View File

@@ -20,6 +20,7 @@ const privileges = require('../src/privileges');
const meta = require('../src/meta'); const meta = require('../src/meta');
const User = require('../src/user'); const User = require('../src/user');
const groups = require('../src/groups'); const groups = require('../src/groups');
const utils = require('../src/utils');
const helpers = require('./helpers'); const helpers = require('./helpers');
const socketPosts = require('../src/socket.io/posts'); const socketPosts = require('../src/socket.io/posts');
const socketTopics = require('../src/socket.io/topics'); const socketTopics = require('../src/socket.io/topics');
@@ -324,6 +325,51 @@ describe('Topic\'s', () => {
}); });
}); });
it('should fail to create new reply with toPid that has been purged', async () => {
const { postData } = await topics.post({
uid: topic.userId,
cid: topic.categoryId,
title: utils.generateUUID(),
content: utils.generateUUID(),
});
await posts.purge(postData.pid, topic.userId);
await assert.rejects(
topics.reply({ uid: topic.userId, content: 'test post', tid: postData.topic.tid, toPid: postData.pid }),
{ message: '[[error:invalid-pid]]' }
);
});
it('should fail to create a new reply with toPid that has been deleted (user cannot view_deleted)', async () => {
const { postData } = await topics.post({
uid: topic.userId,
cid: topic.categoryId,
title: utils.generateUUID(),
content: utils.generateUUID(),
});
await posts.delete(postData.pid, topic.userId);
const uid = await User.create({ username: utils.generateUUID().slice(0, 10) });
await assert.rejects(
topics.reply({ uid, content: 'test post', tid: postData.topic.tid, toPid: postData.pid }),
{ message: '[[error:invalid-pid]]' }
);
});
it('should properly create a new reply with toPid that has been deleted (user\'s own deleted post)', async () => {
const { postData } = await topics.post({
uid: topic.userId,
cid: topic.categoryId,
title: utils.generateUUID(),
content: utils.generateUUID(),
});
await posts.delete(postData.pid, topic.userId);
const uid = await User.create({ username: utils.generateUUID().slice(0, 10) });
const { pid } = await topics.reply({ uid: topic.userId, content: 'test post', tid: postData.topic.tid, toPid: postData.pid });
assert(pid);
});
it('should delete nested relies properly', async () => { it('should delete nested relies properly', async () => {
const result = await topics.post({ uid: fooUid, title: 'nested test', content: 'main post', cid: topic.categoryId }); const result = await topics.post({ uid: fooUid, title: 'nested test', content: 'main post', cid: topic.categoryId });
const reply1 = await topics.reply({ uid: fooUid, content: 'reply post 1', tid: result.topicData.tid }); const reply1 = await topics.reply({ uid: fooUid, content: 'reply post 1', tid: result.topicData.tid });