Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore(api): add deprecation notices re: #9123

Browse Source
This commit is contained in:
Julian Lam
2020-12-28 19:38:22 -05:00
parent e267f29584
commit cdff8d286a
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/controllers/api.js
View File

@@ -2,6 +2,7 @@
const validator = require('validator'); const validator = require('validator');
const nconf = require('nconf'); const nconf = require('nconf');
const winston = require('winston');
const meta = require('../meta'); const meta = require('../meta');
const user = require('../user'); const user = require('../user');
@@ -152,6 +153,10 @@ apiController.getObject = async function (req, res, next) {
if (!method) { if (!method) {
return next(); return next();
} }
winston.warn('[api] This route has been deprecated and will likely be removed in v1.17.0');
winston.warn('[api] Use GET /api/v3/(posts|topics|categories)/:id instead');
try { try {
const result = await method(req.params.id, req.uid); const result = await method(req.params.id, req.uid);
if (!result) { if (!result) {

1
src/routes/api.js
View File

@@ -19,6 +19,7 @@ module.exports = function (app, middleware, controllers) {
router.get('/user/uid/:userslug/export/uploads', middleware.checkAccountPermissions, middleware.exposeUid, controllers.user.exportUploads); router.get('/user/uid/:userslug/export/uploads', middleware.checkAccountPermissions, middleware.exposeUid, controllers.user.exportUploads);
router.get('/user/uid/:userslug/export/profile', middleware.checkAccountPermissions, middleware.exposeUid, controllers.user.exportProfile); router.get('/user/uid/:userslug/export/profile', middleware.checkAccountPermissions, middleware.exposeUid, controllers.user.exportProfile);
// TODO: Deprecate in v1.17.0
router.get('/:type/pid/:id', middleware.authenticateOrGuest, controllers.api.getObject); router.get('/:type/pid/:id', middleware.authenticateOrGuest, controllers.api.getObject);
router.get('/:type/tid/:id', middleware.authenticateOrGuest, controllers.api.getObject); router.get('/:type/tid/:id', middleware.authenticateOrGuest, controllers.api.getObject);
router.get('/:type/cid/:id', middleware.authenticateOrGuest, controllers.api.getObject); router.get('/:type/cid/:id', middleware.authenticateOrGuest, controllers.api.getObject);