Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 03:26:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

closes #6481

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2018-05-02 13:49:08 -04:00
parent 1f8b000530
commit cdc3ef09e9
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/groups/create.js
View File

@@ -91,7 +91,7 @@ module.exports = function (Groups) {
return callback(new Error('[[error:group-name-too-long]]')); return callback(new Error('[[error:group-name-too-long]]'));
} }
if (!Groups.isPrivilegeGroup(name) && name.includes(':')) { if (name === 'guests' || (!Groups.isPrivilegeGroup(name) && name.includes(':'))) {
return callback(new Error('[[error:invalid-group-name]]')); return callback(new Error('[[error:invalid-group-name]]'));
} }

10
test/groups.js
View File

@@ -942,6 +942,16 @@ describe('Groups', function () {
}); });
}); });
it('should fail to create a group with name guests', function (done) {
var oldValue = meta.config.allowGroupCreation;
meta.config.allowGroupCreation = 1;
socketGroups.create({ uid: adminUid }, { name: 'guests' }, function (err) {
meta.config.allowGroupCreation = oldValue;
assert.equal(err.message, '[[error:invalid-group-name]]');
done();
});
});
it('should fail to rename guests group', function (done) { it('should fail to rename guests group', function (done) {
var data = { var data = {
groupName: 'guests', groupName: 'guests',