From cdaea61136f05e2f42a7aeb9f999f19e8517b8fb Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Fri, 3 Sep 2021 15:53:25 -0400
Subject: [PATCH] fix: handle missing uid in deprecated socket call

---
 src/socket.io/user/picture.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/socket.io/user/picture.js b/src/socket.io/user/picture.js
index 186ab02835..7de2ef7165 100644
--- a/src/socket.io/user/picture.js
+++ b/src/socket.io/user/picture.js
@@ -8,6 +8,10 @@ const api = require('../../api');
 
 module.exports = function (SocketUser) {
 	SocketUser.changePicture = async function (socket, data) {
+		if (!socket.uid) {
+			throw new Error('[[error:invalid-uid]]');
+		}
+
 		websockets.warnDeprecated(socket, 'PUT /api/v3/users/:uid/picture');
 		await api.users.changePicture(socket, data);
 	};