Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent crash if groups is not valid json

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-12-13 19:19:56 -05:00
parent 968d461692
commit cc0a087a70
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/navigation/admin.js
View File

@@ -1,6 +1,7 @@
'use strict'; 'use strict';
const validator = require('validator'); const validator = require('validator');
const winston = require('winston');
const plugins = require('../plugins'); const plugins = require('../plugins');
const db = require('../database'); const db = require('../database');
@@ -66,7 +67,12 @@ admin.get = async function () {
const data = await db.getObjects(ids.map(id => `navigation:enabled:${id}`)); const data = await db.getObjects(ids.map(id => `navigation:enabled:${id}`));
cache = data.map((item) => { cache = data.map((item) => {
if (item.hasOwnProperty('groups')) { if (item.hasOwnProperty('groups')) {
try {
item.groups = JSON.parse(item.groups); item.groups = JSON.parse(item.groups);
} catch (err) {
winston.error(err.stack);
item.groups = [];
}
} }
item.groups = item.groups || []; item.groups = item.groups || [];
if (item.groups && !Array.isArray(item.groups)) { if (item.groups && !Array.isArray(item.groups)) {