Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-03 04:25:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

make all admin routes only accesible to admins

Browse Source
This commit is contained in:
Baris Soner Usakli
2013-11-28 22:29:32 -05:00
parent db98b3db55
commit c5f9f896b2
3 changed files with 32 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/routes/admin.js
View File

@@ -14,8 +14,11 @@ var user = require('./../user.js'),
(function (Admin) { (function (Admin) {
Admin.isAdmin = function (req, res, next) { Admin.isAdmin = function (req, res, next) {
user.isAdministrator((req.user && req.user.uid) ? req.user.uid : 0, function (err, isAdmin) { user.isAdministrator((req.user && req.user.uid) ? req.user.uid : 0, function (err, isAdmin) {
if (!isAdmin) res.redirect('/403'); if (!isAdmin) {
else next(); res.redirect('/403');
} else {
next();
}
}); });
} }
@@ -43,6 +46,9 @@ var user = require('./../user.js'),
Admin.createRoutes = function (app) { Admin.createRoutes = function (app) {
app.all('/api/admin/*', Admin.isAdmin);
app.all('/admin/*', Admin.isAdmin);
(function () { (function () {
var routes = [ var routes = [
'categories/active', 'categories/disabled', 'users', 'topics', 'settings', 'themes', 'categories/active', 'categories/disabled', 'users', 'topics', 'settings', 'themes',
@@ -53,7 +59,7 @@ var user = require('./../user.js'),
for (var i = 0, ii = routes.length; i < ii; i++) { for (var i = 0, ii = routes.length; i < ii; i++) {
(function (route) { (function (route) {
app.get('/admin/' + route, Admin.isAdmin, function (req, res) { app.get('/admin/' + route, function (req, res) {
Admin.buildHeader(req, res, function(err, header) { Admin.buildHeader(req, res, function(err, header) {
res.send(header + app.create_route('admin/' + route) + templates['admin/footer']); res.send(header + app.create_route('admin/' + route) + templates['admin/footer']);
}); });
@@ -65,7 +71,7 @@ var user = require('./../user.js'),
for (var i = 0, ii = unit_tests.length; i < ii; i++) { for (var i = 0, ii = unit_tests.length; i < ii; i++) {
(function (route) { (function (route) {
app.get('/admin/testing/' + route, Admin.isAdmin, function (req, res) { app.get('/admin/testing/' + route, function (req, res) {
Admin.buildHeader(req, res, function(err, header) { Admin.buildHeader(req, res, function(err, header) {
res.send(header + app.create_route('admin/testing/' + route) + templates['admin/footer']); res.send(header + app.create_route('admin/testing/' + route) + templates['admin/footer']);
}); });
@@ -76,19 +82,19 @@ var user = require('./../user.js'),
}()); }());
app.namespace('/admin', function () { app.namespace('/admin', function () {
app.get('/', Admin.isAdmin, function (req, res) { app.get('/', function (req, res) {
Admin.buildHeader(req, res, function(err, header) { Admin.buildHeader(req, res, function(err, header) {
res.send(header + app.create_route('admin/index') + templates['admin/footer']); res.send(header + app.create_route('admin/index') + templates['admin/footer']);
}); });
}); });
app.get('/index', Admin.isAdmin, function (req, res) { app.get('/index', function (req, res) {
Admin.buildHeader(req, res, function(err, header) { Admin.buildHeader(req, res, function(err, header) {
res.send(header + app.create_route('admin/index') + templates['admin/footer']); res.send(header + app.create_route('admin/index') + templates['admin/footer']);
}); });
}); });
app.post('/uploadlogo', Admin.isAdmin, function(req, res) { app.post('/uploadlogo', function(req, res) {
if (!req.user) if (!req.user)
return res.redirect('/403'); return res.redirect('/403');
@@ -163,7 +169,9 @@ var user = require('./../user.js'),
}); });
}); });
app.namespace('/api/admin', function () { app.namespace('/api/admin', function () {
app.get('/index', function (req, res) { app.get('/index', function (req, res) {
res.json({ res.json({
version: pkg.version, version: pkg.version,
@@ -282,7 +290,7 @@ var user = require('./../user.js'),
}); });
}); });
// app.get('/export', Admin.isAdmin, function (req, res) { // app.get('/export', function (req, res) {
// Meta.db.getFile(function (err, dbFile) { // Meta.db.getFile(function (err, dbFile) {
// if (!err) { // if (!err) {
// res.download(dbFile, 'redis.rdb', function (err) { // res.download(dbFile, 'redis.rdb', function (err) {

16
src/routes/debug.js
View File

@@ -62,6 +62,22 @@ var DebugRoute = function(app) {
res.send('pruned'); res.send('pruned');
}); });
}); });
app.get('/reindex', function (req, res) {
topics.reIndexAll(function (err) {
if (err) {
return res.json(err);
}
user.reIndexAll(function (err) {
if (err) {
return res.json(err);
} else {
res.send('Topics and users reindexed');
}
});
});
});
}); });
}; };

16
src/webserver.js
View File

@@ -735,22 +735,6 @@ var path = require('path'),
}); });
}); });
app.get('/reindex', function (req, res) {
topics.reIndexAll(function (err) {
if (err) {
return res.json(err);
}
user.reIndexAll(function (err) {
if (err) {
return res.json(err);
} else {
res.send('Topics and users reindexed');
}
});
});
});
// Other routes // Other routes
require('./routes/plugins')(app); require('./routes/plugins')(app);