Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #10491, don't leak deleted message in cleanedContent

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2022-04-12 15:36:06 -04:00
parent 7c733e9cf1
commit c52401da02
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/messaging/index.js
View File

@@ -48,6 +48,7 @@ Messaging.getMessages = async (params) => {
messageData.isOwner = messageData.fromuid === parseInt(params.uid, 10); messageData.isOwner = messageData.fromuid === parseInt(params.uid, 10);
if (messageData.deleted && !messageData.isOwner) { if (messageData.deleted && !messageData.isOwner) {
messageData.content = '[[modules:chat.message-deleted]]'; messageData.content = '[[modules:chat.message-deleted]]';
messageData.cleanedContent = messageData.content;
} }
}); });

1
test/messaging.js
View File

@@ -702,6 +702,7 @@ describe('Messaging Library', () => {
assert.ifError(err); assert.ifError(err);
messages.forEach((msg) => { messages.forEach((msg) => {
assert(!msg.deleted || msg.content === '[[modules:chat.message-deleted]]', msg.content); assert(!msg.deleted || msg.content === '[[modules:chat.message-deleted]]', msg.content);
assert(!msg.deleted || msg.cleanedContent, '[[modules:chat.message-deleted]]', msg.content);
}); });
done(); done();
} }