Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 19:15:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

async.each for get_userslugs_by_uids

Browse Source
This commit is contained in:
Baris Soner Usakli
2013-07-05 18:24:29 -04:00
parent 1c855ce502
commit c47db0e908
1 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/user.js
View File

@@ -532,7 +532,6 @@ var utils = require('./../public/src/utils.js'),
} }
function iterator(uid, callback) { function iterator(uid, callback) {
User.getUserField(uid, 'userslug', function(userslug) { User.getUserField(uid, 'userslug', function(userslug) {
userslugs.push(userslug); userslugs.push(userslug);
callback(null); callback(null);
@@ -540,22 +539,8 @@ var utils = require('./../public/src/utils.js'),
} }
async.each(uids, iterator, function(err) { async.each(uids, iterator, function(err) {
callback(userslugs); callback(userslugs);
}); });
// @todo - rework this logic. it doesn't make much sense when you're going through
// each and then placing the check logic into the innermost callback.
// this is probably a situation where an async.method is ideal
/*for(var i=0, ii=uids.length; i<ii; ++i) {
User.getUserField(uids[i],'userslug', function(userslug) {
userslugs.push(userslug);
if(userslugs.length >= uids.length) {
callback(userslugs);
}
});
}*/
} }
User.get_uid_by_email = function(email, callback) { User.get_uid_by_email = function(email, callback) {