Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 03:26:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

late night optimizations

Browse Source 
-isMemberOfSets returns true/false instead of 1/0
-when loading the posts of a topic only get the userdata for each user
once, before this commit if a topic had 10 posts from 2 different users
we were getting the user data for each user 5 times (drunk)
-getVoteStatusByPostIDs and getFavouritesByPostIDs no longer make
pids.length calls to the db, they use isMemberOfSets now
-getUserInfoForPost renamed to getUserInfoForPosts and doesnt make
uids.length calls to db, uses getMultipleUserFields instead
This commit is contained in:
barisusakli
2014-06-28 01:03:26 -04:00
parent d3fc71529a
commit c3a9767bf6
9 changed files with 137 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
src/posts.js
View File

@@ -188,43 +188,46 @@ var async = require('async'),
});
};
Posts.getUserInfoForPost = function(post, callback) {
user.getUserFields(post.uid, ['username', 'userslug', 'reputation', 'postcount', 'picture', 'signature', 'banned'], function(err, userData) {
Posts.getUserInfoForPosts = function(uids, callback) {
user.getMultipleUserFields(uids, ['uid', 'username', 'userslug', 'reputation', 'postcount', 'picture', 'signature', 'banned'], function(err, userData) {
if (err) {
return callback(err);
}
var userInfo = {
username: userData.username || '[[global:guest]]',
userslug: userData.userslug || '',
reputation: userData.reputation || 0,
postcount: userData.postcount || 0,
banned: parseInt(userData.banned, 10) === 1,
picture: userData.picture || user.createGravatarURLFromEmail('')
};
async.map(userData, function(userData, next) {
var userInfo = {
uid: userData.uid,
username: userData.username || '[[global:guest]]',
userslug: userData.userslug || '',
reputation: userData.reputation || 0,
postcount: userData.postcount || 0,
banned: parseInt(userData.banned, 10) === 1,
picture: userData.picture || user.createGravatarURLFromEmail('')
};
async.parallel({
signature: function(next) {
if (parseInt(meta.config.disableSignatures, 10) === 1) {
return next();
async.parallel({
signature: function(next) {
if (parseInt(meta.config.disableSignatures, 10) === 1) {
return next();
}
postTools.parseSignature(userData.signature, next);
},
customProfileInfo: function(next) {
plugins.fireHook('filter:posts.custom_profile_info', {profile: [], uid: userData.uid}, next);
},
groups: function(next) {
groups.getUserGroups(userData.uid, next);
}
postTools.parseSignature(userData.signature, next);
},
customProfileInfo: function(next) {
plugins.fireHook('filter:posts.custom_profile_info', {profile: [], uid: post.uid, pid: post.pid}, next);
},
groups: function(next) {
groups.getUserGroups(post.uid, next);
}
}, function(err, results) {
if (err) {
return callback(err);
}
userInfo.signature = results.signature;
userInfo.custom_profile_info = results.custom_profile_info;
userInfo.groups = results.groups;
callback(null, userInfo);
});
}, function(err, results) {
if (err) {
return next(err);
}
userInfo.signature = results.signature;
userInfo.custom_profile_info = results.custom_profile_info;
userInfo.groups = results.groups;
next(null, userInfo);
});
}, callback);
});
};