Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 02:55:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #8135

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-01-31 22:56:55 -05:00
parent 1e50616c13
commit c35a21d7f0
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/groups/data.js
View File

@@ -53,6 +53,11 @@ module.exports = function (Groups) {
return Array.isArray(groupsData) && groupsData[0] ? groupsData[0] : null;
};
Groups.getGroupField = async function (groupName, field) {
const groupData = await Groups.getGroupFields(groupName, [field]);
return groupData ? groupData[field] : null;
};
Groups.getGroupFields = async function (groupName, fields) {
const groups = await Groups.getGroupsFields([groupName], fields);
return groups ? groups[0] : null;

6
src/socket.io/groups.js
View File

@@ -375,10 +375,12 @@ async function canModifyGroup(uid, groupName) {
}
const results = await utils.promiseParallel({
isOwner: groups.ownership.isOwner(uid, groupName),
isAdminOrGlobalMod: user.isAdminOrGlobalMod(uid),
system: groups.getGroupField(groupName, 'system'),
isAdmin: user.isAdministrator(uid),
isGlobalMod: user.isGlobalModerator(uid),
});
if (!results.isOwner && !results.isAdminOrGlobalMod) {
if (!(results.isOwner || results.isAdmin || (results.isGlobalMod && !results.system))) {
throw new Error('[[error:no-privileges]]');
}
}