mirror of
https://github.com/NodeBB/NodeBB.git
synced 2025-11-01 11:35:55 +01:00
* axios migration * controller tests * add missing deps * feeds * remove unused async * flags * locale-detect * messaging/middleware * remove log * meta * plugins * posts * search * topics/thumbs * user/emails * uploads.js * socket.io * cleaunup * test native fetch * cleanup * increase engine to 18 fix remaining tests * remove testing file * fix comments,typo * revert debug
This commit is contained in:
committed by
GitHub
parent
451430006e
commit
c15bdd4cf0
@@ -3,12 +3,9 @@
|
||||
|
||||
const assert = require('assert');
|
||||
const url = require('url');
|
||||
const async = require('async');
|
||||
const nconf = require('nconf');
|
||||
const request = require('request');
|
||||
const requestAsync = require('request-promise-native');
|
||||
const util = require('util');
|
||||
|
||||
const request = require('../src/request');
|
||||
const db = require('./mocks/databasemock');
|
||||
const user = require('../src/user');
|
||||
const utils = require('../src/utils');
|
||||
@@ -45,8 +42,8 @@ describe('authentication', () => {
|
||||
it('should allow login with email for uid 1', async () => {
|
||||
const oldValue = meta.config.allowLoginWith;
|
||||
meta.config.allowLoginWith = 'username-email';
|
||||
const { res } = await helpers.loginUser('regular@nodebb.org', 'regularpwd');
|
||||
assert.strictEqual(res.statusCode, 200);
|
||||
const { response } = await helpers.loginUser('regular@nodebb.org', 'regularpwd');
|
||||
assert.strictEqual(response.statusCode, 200);
|
||||
meta.config.allowLoginWith = oldValue;
|
||||
});
|
||||
|
||||
@@ -54,150 +51,112 @@ describe('authentication', () => {
|
||||
const oldValue = meta.config.allowLoginWith;
|
||||
meta.config.allowLoginWith = 'username-email';
|
||||
const uid = await user.create({ username: '2nduser', password: '2ndpassword', email: '2nduser@nodebb.org' });
|
||||
const { res, body } = await helpers.loginUser('2nduser@nodebb.org', '2ndpassword');
|
||||
assert.strictEqual(res.statusCode, 403);
|
||||
const { response, body } = await helpers.loginUser('2nduser@nodebb.org', '2ndpassword');
|
||||
assert.strictEqual(response.statusCode, 403);
|
||||
assert.strictEqual(body, '[[error:invalid-login-credentials]]');
|
||||
meta.config.allowLoginWith = oldValue;
|
||||
});
|
||||
|
||||
it('should fail to create user if username is too short', (done) => {
|
||||
helpers.registerUser({
|
||||
it('should fail to create user if username is too short', async () => {
|
||||
const { response, body } = await helpers.registerUser({
|
||||
username: 'a',
|
||||
password: '123456',
|
||||
}, (err, jar, response, body) => {
|
||||
assert.ifError(err);
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-short]]');
|
||||
done();
|
||||
});
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-short]]');
|
||||
});
|
||||
|
||||
it('should fail to create user if userslug is too short', (done) => {
|
||||
helpers.registerUser({
|
||||
it('should fail to create user if userslug is too short', async () => {
|
||||
const { response, body } = await helpers.registerUser({
|
||||
username: '----a-----',
|
||||
password: '123456',
|
||||
}, (err, jar, response, body) => {
|
||||
assert.ifError(err);
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-short]]');
|
||||
done();
|
||||
});
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-short]]');
|
||||
});
|
||||
|
||||
it('should fail to create user if userslug is too short', (done) => {
|
||||
helpers.registerUser({
|
||||
it('should fail to create user if userslug is too short', async () => {
|
||||
const { response, body } = await helpers.registerUser({
|
||||
username: ' a',
|
||||
password: '123456',
|
||||
}, (err, jar, response, body) => {
|
||||
assert.ifError(err);
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-short]]');
|
||||
done();
|
||||
});
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-short]]');
|
||||
});
|
||||
|
||||
it('should fail to create user if userslug is too short', (done) => {
|
||||
helpers.registerUser({
|
||||
it('should fail to create user if userslug is too short', async () => {
|
||||
const { response, body } = await helpers.registerUser({
|
||||
username: 'a ',
|
||||
password: '123456',
|
||||
}, (err, jar, response, body) => {
|
||||
assert.ifError(err);
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-short]]');
|
||||
done();
|
||||
});
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-short]]');
|
||||
});
|
||||
|
||||
it('should register and login a user', (done) => {
|
||||
request({
|
||||
url: `${nconf.get('url')}/api/config`,
|
||||
json: true,
|
||||
it('should register and login a user', async () => {
|
||||
const jar = request.jar();
|
||||
const csrf_token = await helpers.getCsrfToken(jar);
|
||||
|
||||
const { body } = await request.post(`${nconf.get('url')}/register`, {
|
||||
jar,
|
||||
body: {
|
||||
email: 'admin@nodebb.org',
|
||||
username: 'admin',
|
||||
password: 'adminpwd',
|
||||
'password-confirm': 'adminpwd',
|
||||
userLang: 'it',
|
||||
gdpr_consent: true,
|
||||
},
|
||||
headers: {
|
||||
'x-csrf-token': csrf_token,
|
||||
},
|
||||
});
|
||||
|
||||
const validationPending = await user.email.isValidationPending(body.uid, 'admin@nodebb.org');
|
||||
assert.strictEqual(validationPending, true);
|
||||
|
||||
assert(body);
|
||||
assert(body.hasOwnProperty('uid') && body.uid > 0);
|
||||
const newUid = body.uid;
|
||||
const { body: self } = await request.get(`${nconf.get('url')}/api/self`, {
|
||||
jar,
|
||||
});
|
||||
assert(self);
|
||||
assert.equal(self.username, 'admin');
|
||||
assert.equal(self.uid, newUid);
|
||||
const settings = await user.getSettings(body.uid);
|
||||
assert.equal(settings.userLang, 'it');
|
||||
});
|
||||
|
||||
it('should logout a user', async () => {
|
||||
await helpers.logoutUser(jar);
|
||||
|
||||
const { response, body } = await request.get(`${nconf.get('url')}/api/me`, {
|
||||
jar: jar,
|
||||
}, (err, response, body) => {
|
||||
assert.ifError(err);
|
||||
|
||||
request.post(`${nconf.get('url')}/register`, {
|
||||
form: {
|
||||
email: 'admin@nodebb.org',
|
||||
username: 'admin',
|
||||
password: 'adminpwd',
|
||||
'password-confirm': 'adminpwd',
|
||||
userLang: 'it',
|
||||
gdpr_consent: true,
|
||||
},
|
||||
json: true,
|
||||
jar: jar,
|
||||
headers: {
|
||||
'x-csrf-token': body.csrf_token,
|
||||
},
|
||||
}, async (err, response, body) => {
|
||||
const validationPending = await user.email.isValidationPending(body.uid, 'admin@nodebb.org');
|
||||
assert.strictEqual(validationPending, true);
|
||||
assert.ifError(err);
|
||||
assert(body);
|
||||
assert(body.hasOwnProperty('uid') && body.uid > 0);
|
||||
const newUid = body.uid;
|
||||
request({
|
||||
url: `${nconf.get('url')}/api/self`,
|
||||
json: true,
|
||||
jar: jar,
|
||||
}, (err, response, body) => {
|
||||
assert.ifError(err);
|
||||
assert(body);
|
||||
assert.equal(body.username, 'admin');
|
||||
assert.equal(body.uid, newUid);
|
||||
user.getSettings(body.uid, (err, settings) => {
|
||||
assert.ifError(err);
|
||||
assert.equal(settings.userLang, 'it');
|
||||
done();
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
it('should logout a user', (done) => {
|
||||
helpers.logoutUser(jar, (err) => {
|
||||
assert.ifError(err);
|
||||
request({
|
||||
url: `${nconf.get('url')}/api/me`,
|
||||
json: true,
|
||||
jar: jar,
|
||||
}, (err, res, body) => {
|
||||
assert.ifError(err);
|
||||
assert.equal(res.statusCode, 401);
|
||||
assert.strictEqual(body.status.code, 'not-authorised');
|
||||
done();
|
||||
});
|
||||
});
|
||||
assert.equal(response.statusCode, 401);
|
||||
assert.strictEqual(body.status.code, 'not-authorised');
|
||||
});
|
||||
|
||||
it('should regenerate the session identifier on successful login', async () => {
|
||||
const matchRegexp = /express\.sid=s%3A(.+?);/;
|
||||
const { hostname, path } = url.parse(nconf.get('url'));
|
||||
|
||||
const sid = String(jar._jar.store.idx[hostname][path]['express.sid']).match(matchRegexp)[1];
|
||||
const sid = String(jar.store.idx[hostname][path]['express.sid']).match(matchRegexp)[1];
|
||||
await helpers.logoutUser(jar);
|
||||
const newJar = (await helpers.loginUser('regular', 'regularpwd')).jar;
|
||||
const newSid = String(newJar._jar.store.idx[hostname][path]['express.sid']).match(matchRegexp)[1];
|
||||
const newSid = String(newJar.store.idx[hostname][path]['express.sid']).match(matchRegexp)[1];
|
||||
|
||||
assert.notStrictEqual(newSid, sid);
|
||||
});
|
||||
|
||||
it('should revoke all sessions', (done) => {
|
||||
|
||||
it('should revoke all sessions', async () => {
|
||||
const socketAdmin = require('../src/socket.io/admin');
|
||||
db.sortedSetCard(`uid:${regularUid}:sessions`, (err, count) => {
|
||||
assert.ifError(err);
|
||||
assert(count);
|
||||
socketAdmin.deleteAllSessions({ uid: 1 }, {}, (err) => {
|
||||
assert.ifError(err);
|
||||
db.sortedSetCard(`uid:${regularUid}:sessions`, (err, count) => {
|
||||
assert.ifError(err);
|
||||
assert(!count);
|
||||
done();
|
||||
});
|
||||
});
|
||||
});
|
||||
let sessionCount = await db.sortedSetCard(`uid:${regularUid}:sessions`);
|
||||
assert(sessionCount);
|
||||
await socketAdmin.deleteAllSessions({ uid: 1 }, {});
|
||||
sessionCount = await db.sortedSetCard(`uid:${regularUid}:sessions`);
|
||||
assert(!sessionCount);
|
||||
});
|
||||
|
||||
describe('login', () => {
|
||||
@@ -205,11 +164,12 @@ describe('authentication', () => {
|
||||
let password;
|
||||
let uid;
|
||||
|
||||
function getCookieExpiry(res) {
|
||||
assert(res.headers['set-cookie']);
|
||||
assert.strictEqual(res.headers['set-cookie'][0].includes('Expires'), true);
|
||||
function getCookieExpiry(response) {
|
||||
const { headers } = response;
|
||||
assert(headers['set-cookie']);
|
||||
assert.strictEqual(headers['set-cookie'].includes('Expires'), true);
|
||||
|
||||
const values = res.headers['set-cookie'][0].split(';');
|
||||
const values = headers['set-cookie'].split(';');
|
||||
return values.reduce((memo, cur) => {
|
||||
if (!memo) {
|
||||
const [name, value] = cur.split('=');
|
||||
@@ -230,9 +190,7 @@ describe('authentication', () => {
|
||||
it('should login a user', async () => {
|
||||
const { jar, body: loginBody } = await helpers.loginUser(username, password);
|
||||
assert(loginBody);
|
||||
const body = await requestAsync({
|
||||
url: `${nconf.get('url')}/api/self`,
|
||||
json: true,
|
||||
const { body } = await request.get(`${nconf.get('url')}/api/self`, {
|
||||
jar,
|
||||
});
|
||||
assert(body);
|
||||
@@ -243,11 +201,11 @@ describe('authentication', () => {
|
||||
});
|
||||
|
||||
it('should set a cookie that only lasts for the life of the browser session', async () => {
|
||||
const { res } = await helpers.loginUser(username, password);
|
||||
const { response } = await helpers.loginUser(username, password);
|
||||
|
||||
assert(res.headers);
|
||||
assert(res.headers['set-cookie']);
|
||||
assert.strictEqual(res.headers['set-cookie'][0].includes('Expires'), false);
|
||||
assert(response.headers);
|
||||
assert(response.headers['set-cookie']);
|
||||
assert.strictEqual(response.headers['set-cookie'].includes('Expires'), false);
|
||||
});
|
||||
|
||||
it('should set a different expiry if sessionDuration is set', async () => {
|
||||
@@ -255,9 +213,9 @@ describe('authentication', () => {
|
||||
const days = 1;
|
||||
meta.config.sessionDuration = days * 24 * 60 * 60;
|
||||
|
||||
const { res } = await helpers.loginUser(username, password);
|
||||
const { response } = await helpers.loginUser(username, password);
|
||||
|
||||
const expiry = getCookieExpiry(res);
|
||||
const expiry = getCookieExpiry(response);
|
||||
const expected = new Date();
|
||||
expected.setUTCDate(expected.getUTCDate() + days);
|
||||
|
||||
@@ -267,9 +225,9 @@ describe('authentication', () => {
|
||||
});
|
||||
|
||||
it('should set a cookie that lasts for x days where x is loginDays setting, if asked to remember', async () => {
|
||||
const { res } = await helpers.loginUser(username, password, { remember: 'on' });
|
||||
const { response } = await helpers.loginUser(username, password, { remember: 'on' });
|
||||
|
||||
const expiry = getCookieExpiry(res);
|
||||
const expiry = getCookieExpiry(response);
|
||||
const expected = new Date();
|
||||
expected.setUTCDate(expected.getUTCDate() + meta.config.loginDays);
|
||||
|
||||
@@ -280,9 +238,9 @@ describe('authentication', () => {
|
||||
const _loginDays = meta.config.loginDays;
|
||||
meta.config.loginDays = 5;
|
||||
|
||||
const { res } = await helpers.loginUser(username, password, { remember: 'on' });
|
||||
const { response } = await helpers.loginUser(username, password, { remember: 'on' });
|
||||
|
||||
const expiry = getCookieExpiry(res);
|
||||
const expiry = getCookieExpiry(response);
|
||||
const expected = new Date();
|
||||
expected.setUTCDate(expected.getUTCDate() + meta.config.loginDays);
|
||||
|
||||
@@ -295,9 +253,9 @@ describe('authentication', () => {
|
||||
const _loginSeconds = meta.config.loginSeconds;
|
||||
meta.config.loginSeconds = 60;
|
||||
|
||||
const { res } = await helpers.loginUser(username, password, { remember: 'on' });
|
||||
const { response } = await helpers.loginUser(username, password, { remember: 'on' });
|
||||
|
||||
const expiry = getCookieExpiry(res);
|
||||
const expiry = getCookieExpiry(response);
|
||||
const expected = new Date();
|
||||
expected.setUTCSeconds(expected.getUTCSeconds() + meta.config.loginSeconds);
|
||||
|
||||
@@ -308,158 +266,128 @@ describe('authentication', () => {
|
||||
});
|
||||
});
|
||||
|
||||
it('should fail to login if ip address is invalid', (done) => {
|
||||
it('should fail to login if ip address is invalid', async () => {
|
||||
const jar = request.jar();
|
||||
request({
|
||||
url: `${nconf.get('url')}/api/config`,
|
||||
json: true,
|
||||
jar: jar,
|
||||
}, (err, response, body) => {
|
||||
if (err) {
|
||||
return done(err);
|
||||
}
|
||||
const csrf_token = await helpers.getCsrfToken(jar);
|
||||
|
||||
request.post(`${nconf.get('url')}/login`, {
|
||||
form: {
|
||||
username: 'regular',
|
||||
password: 'regularpwd',
|
||||
},
|
||||
json: true,
|
||||
jar: jar,
|
||||
headers: {
|
||||
'x-csrf-token': body.csrf_token,
|
||||
'x-forwarded-for': '<script>alert("xss")</script>',
|
||||
},
|
||||
}, (err, response, body) => {
|
||||
assert.ifError(err);
|
||||
assert.equal(response.statusCode, 500);
|
||||
done();
|
||||
});
|
||||
const { response } = await request.post(`${nconf.get('url')}/login`, {
|
||||
body: {
|
||||
username: 'regular',
|
||||
password: 'regularpwd',
|
||||
},
|
||||
jar: jar,
|
||||
headers: {
|
||||
'x-csrf-token': csrf_token,
|
||||
'x-forwarded-for': '<script>alert("xss")</script>',
|
||||
},
|
||||
});
|
||||
assert.equal(response.status, 500);
|
||||
});
|
||||
|
||||
it('should fail to login if user does not exist', async () => {
|
||||
const { res, body } = await helpers.loginUser('doesnotexist', 'nopassword');
|
||||
assert.equal(res.statusCode, 403);
|
||||
const { response, body } = await helpers.loginUser('doesnotexist', 'nopassword');
|
||||
assert.equal(response.statusCode, 403);
|
||||
assert.equal(body, '[[error:invalid-login-credentials]]');
|
||||
});
|
||||
|
||||
it('should fail to login if username is empty', async () => {
|
||||
const { res, body } = await helpers.loginUser('', 'some password');
|
||||
assert.equal(res.statusCode, 403);
|
||||
const { response, body } = await helpers.loginUser('', 'some password');
|
||||
assert.equal(response.statusCode, 403);
|
||||
assert.equal(body, '[[error:invalid-username-or-password]]');
|
||||
});
|
||||
|
||||
it('should fail to login if password is empty', async () => {
|
||||
const { res, body } = await helpers.loginUser('someuser', '');
|
||||
assert.equal(res.statusCode, 403);
|
||||
const { response, body } = await helpers.loginUser('someuser', '');
|
||||
assert.equal(response.statusCode, 403);
|
||||
assert.equal(body, '[[error:invalid-username-or-password]]');
|
||||
});
|
||||
|
||||
it('should fail to login if username and password are empty', async () => {
|
||||
const { res, body } = await helpers.loginUser('', '');
|
||||
assert.equal(res.statusCode, 403);
|
||||
const { response, body } = await helpers.loginUser('', '');
|
||||
assert.equal(response.statusCode, 403);
|
||||
assert.equal(body, '[[error:invalid-username-or-password]]');
|
||||
});
|
||||
|
||||
it('should fail to login if user does not have password field in db', async () => {
|
||||
await user.create({ username: 'hasnopassword', email: 'no@pass.org' });
|
||||
const { res, body } = await helpers.loginUser('hasnopassword', 'doesntmatter');
|
||||
assert.equal(res.statusCode, 403);
|
||||
const { response, body } = await helpers.loginUser('hasnopassword', 'doesntmatter');
|
||||
assert.equal(response.statusCode, 403);
|
||||
assert.equal(body, '[[error:invalid-login-credentials]]');
|
||||
});
|
||||
|
||||
it('should fail to login if password is longer than 4096', async () => {
|
||||
let longPassword;
|
||||
let longPassword = '';
|
||||
for (let i = 0; i < 5000; i++) {
|
||||
longPassword += 'a';
|
||||
}
|
||||
const { res, body } = await helpers.loginUser('someuser', longPassword);
|
||||
assert.equal(res.statusCode, 403);
|
||||
const { response, body } = await helpers.loginUser('someuser', longPassword);
|
||||
assert.equal(response.statusCode, 403);
|
||||
assert.equal(body, '[[error:password-too-long]]');
|
||||
});
|
||||
|
||||
it('should fail to login if local login is disabled', async () => {
|
||||
await privileges.global.rescind(['groups:local:login'], 'registered-users');
|
||||
const { res, body } = await helpers.loginUser('regular', 'regularpwd');
|
||||
assert.equal(res.statusCode, 403);
|
||||
const { response, body } = await helpers.loginUser('regular', 'regularpwd');
|
||||
assert.equal(response.statusCode, 403);
|
||||
assert.equal(body, '[[error:local-login-disabled]]');
|
||||
await privileges.global.give(['groups:local:login'], 'registered-users');
|
||||
});
|
||||
|
||||
it('should fail to register if registraton is disabled', (done) => {
|
||||
it('should fail to register if registraton is disabled', async () => {
|
||||
meta.config.registrationType = 'disabled';
|
||||
helpers.registerUser({
|
||||
const { response, body } = await helpers.registerUser({
|
||||
username: 'someuser',
|
||||
password: 'somepassword',
|
||||
}, (err, jar, response, body) => {
|
||||
assert.ifError(err);
|
||||
assert.equal(response.statusCode, 403);
|
||||
assert.equal(body, 'Forbidden');
|
||||
done();
|
||||
});
|
||||
assert.equal(response.statusCode, 403);
|
||||
assert.equal(body, 'Forbidden');
|
||||
});
|
||||
|
||||
it('should return error if invitation is not valid', (done) => {
|
||||
it('should return error if invitation is not valid', async () => {
|
||||
meta.config.registrationType = 'invite-only';
|
||||
helpers.registerUser({
|
||||
const { response, body } = await helpers.registerUser({
|
||||
username: 'someuser',
|
||||
password: 'somepassword',
|
||||
}, (err, jar, response, body) => {
|
||||
meta.config.registrationType = 'normal';
|
||||
assert.ifError(err);
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[register:invite.error-invite-only]]');
|
||||
done();
|
||||
});
|
||||
meta.config.registrationType = 'normal';
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[register:invite.error-invite-only]]');
|
||||
});
|
||||
|
||||
it('should fail to register if username is falsy or too short', (done) => {
|
||||
helpers.registerUser({
|
||||
username: '',
|
||||
password: 'somepassword',
|
||||
}, (err, jar, response, body) => {
|
||||
assert.ifError(err);
|
||||
it('should fail to register if username is falsy or too short', async () => {
|
||||
const userData = [
|
||||
{ username: '', password: 'somepassword' },
|
||||
{ username: 'a', password: 'somepassword' },
|
||||
];
|
||||
for (const user of userData) {
|
||||
// eslint-disable-next-line no-await-in-loop
|
||||
const { response, body } = await helpers.registerUser(user);
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-short]]');
|
||||
helpers.registerUser({
|
||||
username: 'a',
|
||||
password: 'somepassword',
|
||||
}, (err, jar, response, body) => {
|
||||
assert.ifError(err);
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-short]]');
|
||||
done();
|
||||
});
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
it('should fail to register if username is too long', (done) => {
|
||||
helpers.registerUser({
|
||||
it('should fail to register if username is too long', async () => {
|
||||
const { response, body } = await helpers.registerUser({
|
||||
username: 'thisisareallylongusername',
|
||||
password: '123456',
|
||||
}, (err, jar, response, body) => {
|
||||
assert.ifError(err);
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-long]]');
|
||||
done();
|
||||
});
|
||||
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:username-too-long]]');
|
||||
});
|
||||
|
||||
it('should queue user if ip is used before', (done) => {
|
||||
it('should queue user if ip is used before', async () => {
|
||||
meta.config.registrationApprovalType = 'admin-approval-ip';
|
||||
helpers.registerUser({
|
||||
const { response, body } = await helpers.registerUser({
|
||||
email: 'another@user.com',
|
||||
username: 'anotheruser',
|
||||
password: 'anotherpwd',
|
||||
gdpr_consent: 1,
|
||||
}, (err, jar, response, body) => {
|
||||
meta.config.registrationApprovalType = 'normal';
|
||||
assert.ifError(err);
|
||||
assert.equal(response.statusCode, 200);
|
||||
assert.equal(body.message, '[[register:registration-added-to-queue]]');
|
||||
done();
|
||||
});
|
||||
meta.config.registrationApprovalType = 'normal';
|
||||
assert.equal(response.statusCode, 200);
|
||||
assert.equal(body.message, '[[register:registration-added-to-queue]]');
|
||||
});
|
||||
|
||||
|
||||
@@ -468,41 +396,32 @@ describe('authentication', () => {
|
||||
const uid = await user.create({ username: 'ginger', password: '123456', email });
|
||||
await user.setUserField(uid, 'email', email);
|
||||
await user.email.confirmByUid(uid);
|
||||
const { res } = await helpers.loginUser('ginger@nodebb.org', '123456');
|
||||
assert.equal(res.statusCode, 200);
|
||||
const { response } = await helpers.loginUser('ginger@nodebb.org', '123456');
|
||||
assert.equal(response.statusCode, 200);
|
||||
});
|
||||
|
||||
it('should fail to login if login type is username and an email is sent', async () => {
|
||||
meta.config.allowLoginWith = 'username';
|
||||
const { res, body } = await helpers.loginUser('ginger@nodebb.org', '123456');
|
||||
const { response, body } = await helpers.loginUser('ginger@nodebb.org', '123456');
|
||||
meta.config.allowLoginWith = 'username-email';
|
||||
assert.equal(res.statusCode, 400);
|
||||
assert.equal(response.statusCode, 400);
|
||||
assert.equal(body, '[[error:wrong-login-type-username]]');
|
||||
});
|
||||
|
||||
it('should send 200 if not logged in', (done) => {
|
||||
it('should send 200 if not logged in', async () => {
|
||||
const jar = request.jar();
|
||||
request({
|
||||
url: `${nconf.get('url')}/api/config`,
|
||||
json: true,
|
||||
jar: jar,
|
||||
}, (err, response, body) => {
|
||||
assert.ifError(err);
|
||||
const csrf_token = await helpers.getCsrfToken(jar);
|
||||
|
||||
request.post(`${nconf.get('url')}/logout`, {
|
||||
form: {},
|
||||
json: true,
|
||||
jar: jar,
|
||||
headers: {
|
||||
'x-csrf-token': body.csrf_token,
|
||||
},
|
||||
}, (err, res, body) => {
|
||||
assert.ifError(err);
|
||||
assert.equal(res.statusCode, 200);
|
||||
assert.equal(body, 'not-logged-in');
|
||||
done();
|
||||
});
|
||||
const { response, body } = await request.post(`${nconf.get('url')}/logout`, {
|
||||
data: {},
|
||||
jar: jar,
|
||||
headers: {
|
||||
'x-csrf-token': csrf_token,
|
||||
},
|
||||
});
|
||||
|
||||
assert.equal(response.statusCode, 200);
|
||||
assert.equal(body, 'not-logged-in');
|
||||
});
|
||||
|
||||
describe('banned user authentication', () => {
|
||||
@@ -518,7 +437,7 @@ describe('authentication', () => {
|
||||
|
||||
it('should prevent banned user from logging in', async () => {
|
||||
await user.bans.ban(bannedUser.uid, 0, 'spammer');
|
||||
const { res: res1, body: body1 } = await helpers.loginUser(bannedUser.username, bannedUser.pw);
|
||||
const { response: res1, body: body1 } = await helpers.loginUser(bannedUser.username, bannedUser.pw);
|
||||
assert.equal(res1.statusCode, 403);
|
||||
delete body1.timestamp;
|
||||
assert.deepStrictEqual(body1, {
|
||||
@@ -532,7 +451,7 @@ describe('authentication', () => {
|
||||
await user.bans.unban(bannedUser.uid);
|
||||
const expiry = Date.now() + 10000;
|
||||
await user.bans.ban(bannedUser.uid, expiry, '');
|
||||
const { res: res2, body: body2 } = await helpers.loginUser(bannedUser.username, bannedUser.pw);
|
||||
const { response: res2, body: body2 } = await helpers.loginUser(bannedUser.username, bannedUser.pw);
|
||||
assert.equal(res2.statusCode, 403);
|
||||
assert(body2.banned_until);
|
||||
assert(body2.reason, '[[user:info.banned-no-reason]]');
|
||||
@@ -540,15 +459,15 @@ describe('authentication', () => {
|
||||
|
||||
it('should allow banned user to log in if the "banned-users" group has "local-login" privilege', async () => {
|
||||
await privileges.global.give(['groups:local:login'], 'banned-users');
|
||||
const { res } = await helpers.loginUser(bannedUser.username, bannedUser.pw);
|
||||
assert.strictEqual(res.statusCode, 200);
|
||||
const { response } = await helpers.loginUser(bannedUser.username, bannedUser.pw);
|
||||
assert.strictEqual(response.statusCode, 200);
|
||||
});
|
||||
|
||||
it('should allow banned user to log in if the user herself has "local-login" privilege', async () => {
|
||||
await privileges.global.rescind(['groups:local:login'], 'banned-users');
|
||||
await privileges.categories.give(['local:login'], 0, bannedUser.uid);
|
||||
const { res } = await helpers.loginUser(bannedUser.username, bannedUser.pw);
|
||||
assert.strictEqual(res.statusCode, 200);
|
||||
const { response } = await helpers.loginUser(bannedUser.username, bannedUser.pw);
|
||||
assert.strictEqual(response.statusCode, 200);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -561,10 +480,10 @@ describe('authentication', () => {
|
||||
let data = await helpers.loginUser('lockme', 'abcdef');
|
||||
|
||||
meta.config.loginAttempts = 5;
|
||||
assert.equal(data.res.statusCode, 403);
|
||||
assert.equal(data.response.statusCode, 403);
|
||||
assert.equal(data.body, '[[error:account-locked]]');
|
||||
data = await helpers.loginUser('lockme', 'abcdef');
|
||||
assert.equal(data.res.statusCode, 403);
|
||||
assert.equal(data.response.statusCode, 403);
|
||||
assert.equal(data.body, '[[error:account-locked]]');
|
||||
const locked = await db.exists(`lockout:${uid}`);
|
||||
assert(locked);
|
||||
@@ -594,57 +513,46 @@ describe('authentication', () => {
|
||||
});
|
||||
|
||||
it('should fail with invalid token', async () => {
|
||||
const { res, body } = await helpers.request('get', `/api/self`, {
|
||||
form: {
|
||||
_uid: newUid,
|
||||
},
|
||||
json: true,
|
||||
const { response, body } = await helpers.request('get', `/api/self?_uid${newUid}`, {
|
||||
jar: jar,
|
||||
headers: {
|
||||
Authorization: `Bearer sdfhaskfdja-jahfdaksdf`,
|
||||
},
|
||||
});
|
||||
assert.strictEqual(res.statusCode, 401);
|
||||
assert.strictEqual(response.statusCode, 401);
|
||||
assert.strictEqual(body, 'not-authorized');
|
||||
});
|
||||
|
||||
it('should use a token tied to an uid', async () => {
|
||||
const { res, body } = await helpers.request('get', `/api/self`, {
|
||||
json: true,
|
||||
const { response, body } = await helpers.request('get', `/api/self`, {
|
||||
headers: {
|
||||
Authorization: `Bearer ${userToken}`,
|
||||
},
|
||||
});
|
||||
|
||||
assert.strictEqual(res.statusCode, 200);
|
||||
assert.strictEqual(response.statusCode, 200);
|
||||
assert.strictEqual(body.username, 'apiUserTarget');
|
||||
});
|
||||
|
||||
it('should fail if _uid is not passed in with master token', async () => {
|
||||
const { res, body } = await helpers.request('get', `/api/self`, {
|
||||
form: {},
|
||||
json: true,
|
||||
const { response, body } = await helpers.request('get', `/api/self`, {
|
||||
headers: {
|
||||
Authorization: `Bearer ${masterToken}`,
|
||||
},
|
||||
});
|
||||
|
||||
assert.strictEqual(res.statusCode, 500);
|
||||
assert.strictEqual(response.statusCode, 500);
|
||||
assert.strictEqual(body.error, '[[error:api.master-token-no-uid]]');
|
||||
});
|
||||
|
||||
it('should use master api token and _uid', async () => {
|
||||
const { res, body } = await helpers.request('get', `/api/self`, {
|
||||
form: {
|
||||
_uid: newUid,
|
||||
},
|
||||
json: true,
|
||||
const { response, body } = await helpers.request('get', `/api/self?_uid=${newUid}`, {
|
||||
headers: {
|
||||
Authorization: `Bearer ${masterToken}`,
|
||||
},
|
||||
});
|
||||
|
||||
assert.strictEqual(res.statusCode, 200);
|
||||
assert.strictEqual(response.statusCode, 200);
|
||||
assert.strictEqual(body.username, 'apiUserTarget');
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user