Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: buildTopicsSortedSet

Browse Source 
- use Set internally
- if cid -1 and logged in, add user inbox to sets
This commit is contained in:
Julian Lam
2024-10-29 10:35:21 -04:00
parent beb85604bd
commit c1093c928f
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/categories/topics.js
View File

@@ -89,7 +89,7 @@ module.exports = function (Categories) {
}; };
Categories.buildTopicsSortedSet = async function (data) { Categories.buildTopicsSortedSet = async function (data) {
const { cid } = data; const { cid, uid } = data;
const sort = data.sort || (data.settings && data.settings.categoryTopicSort) || meta.config.categoryTopicSort || 'recently_replied'; const sort = data.sort || (data.settings && data.settings.categoryTopicSort) || meta.config.categoryTopicSort || 'recently_replied';
const sortToSet = { const sortToSet = {
recently_replied: `cid:${cid}:tids`, recently_replied: `cid:${cid}:tids`,
@@ -99,22 +99,28 @@ module.exports = function (Categories) {
most_views: `cid:${cid}:tids:views`, most_views: `cid:${cid}:tids:views`,
}; };
let set = sortToSet.hasOwnProperty(sort) ? sortToSet[sort] : `cid:${cid}:tids`; const set = new Set([sortToSet.hasOwnProperty(sort) ? sortToSet[sort] : `cid:${cid}:tids`]);
if (data.tag) { if (data.tag) {
if (Array.isArray(data.tag)) { if (Array.isArray(data.tag)) {
set = [set].concat(data.tag.map(tag => `tag:${tag}:topics`)); data.tag.forEach((tag) => {
set.add(`tag:${tag}:topics`);
});
} else { } else {
set = [set, `tag:${data.tag}:topics`]; set.add(`tag:${data.tag}:topics`);
} }
} }
if (data.targetUid) { if (data.targetUid) {
set = (Array.isArray(set) ? set : [set]).concat([`cid:${cid}:uid:${data.targetUid}:tids`]); set.add(`cid:${cid}:uid:${data.targetUid}:tids`);
}
if (parseInt(cid, 10) === -1 && uid > 0) {
set.add(`uid:${uid}:inbox`);
} }
const result = await plugins.hooks.fire('filter:categories.buildTopicsSortedSet', { const result = await plugins.hooks.fire('filter:categories.buildTopicsSortedSet', {
set: set, set: Array.from(set),
data: data, data: data,
}); });
return result && result.set; return result && result.set;