Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-27 00:56:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #13139, payload.version can be null

Browse Source 
causes compareVersions to crash, show cofirm modal if its null
This commit is contained in:
Barış Soner Uşaklı
2025-02-07 19:34:26 -05:00
parent 2b7961e0e2
commit bfe6d9d861
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
public/src/admin/extend/plugins.js
View File

@@ -136,11 +136,13 @@ define('admin/extend/plugins', [
require(['compare-versions'], function (compareVersions) { require(['compare-versions'], function (compareVersions) {
const currentVersion = parent.find('.currentVersion').text(); const currentVersion = parent.find('.currentVersion').text();
if (payload.version !== 'latest' && compareVersions.compare(payload.version, currentVersion, '>')) { if (payload.version && payload.version !== 'latest' && compareVersions.compare(payload.version, currentVersion, '>')) {
upgrade(pluginID, btn, payload.version); upgrade(pluginID, btn, payload.version);
} else if (payload.version === 'latest') { } else if (payload.version === 'latest' || payload.version === null) {
confirmInstall(pluginID, function () { confirmInstall(pluginID, function (confirm) {
if (confirm) {
upgrade(pluginID, btn, payload.version); upgrade(pluginID, btn, payload.version);
}
}); });
} else { } else {
bootbox.alert(translator.compile('admin/extend/plugins:alert.incompatible', app.config.version, payload.version)); bootbox.alert(translator.compile('admin/extend/plugins:alert.incompatible', app.config.version, payload.version));