From be1598d1713a4de4b52d13e34fd024d0fd5d21c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Fri, 7 Feb 2025 19:34:26 -0500 Subject: [PATCH] fix: #13139, payload.version can be null causes compareVersions to crash, show cofirm modal if its null --- public/src/admin/extend/plugins.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/public/src/admin/extend/plugins.js b/public/src/admin/extend/plugins.js index 6fb820a946..a70a6d17f0 100644 --- a/public/src/admin/extend/plugins.js +++ b/public/src/admin/extend/plugins.js @@ -136,11 +136,13 @@ define('admin/extend/plugins', [ require(['compare-versions'], function (compareVersions) { const currentVersion = parent.find('.currentVersion').text(); - if (payload.version !== 'latest' && compareVersions.compare(payload.version, currentVersion, '>')) { + if (payload.version && payload.version !== 'latest' && compareVersions.compare(payload.version, currentVersion, '>')) { upgrade(pluginID, btn, payload.version); - } else if (payload.version === 'latest') { - confirmInstall(pluginID, function () { - upgrade(pluginID, btn, payload.version); + } else if (payload.version === 'latest' || payload.version === null) { + confirmInstall(pluginID, function (confirm) { + if (confirm) { + upgrade(pluginID, btn, payload.version); + } }); } else { bootbox.alert(translator.compile('admin/extend/plugins:alert.incompatible', app.config.version, payload.version));