Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 02:55:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

prevent double follow/unfollow

Browse Source
This commit is contained in:
barisusakli
2015-02-27 17:57:09 -05:00
parent 5b67cd841e
commit bd17bff7d4
2 changed files with 42 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/socket.io/user.js
View File

@@ -282,28 +282,24 @@ SocketUser.follow = function(socket, data, callback) {
return;
}
toggleFollow('follow', socket.uid, data.uid, function(err) {
if (err) {
return callback(err);
}
user.getUserFields(socket.uid, ['username', 'userslug'], function(err, userData) {
if (err) {
return callback(err);
}
async.waterfall([
function(next) {
toggleFollow('follow', socket.uid, data.uid, next);
},
function(next) {
user.getUserFields(socket.uid, ['username', 'userslug'], next);
},
function(userData, next) {
notifications.create({
bodyShort: '[[notifications:user_started_following_you, ' + userData.username + ']]',
nid: 'follow:' + data.uid + ':uid:' + socket.uid,
from: socket.uid
}, function(err, notification) {
if (!err && notification) {
notifications.push(notification, [data.uid]);
}, next);
},
function(notification, next) {
notifications.push(notification, [data.uid], next);
}
callback(err);
});
});
});
], callback);
};
SocketUser.unfollow = function(socket, data, callback) {

12
src/user/follow.js
View File

@@ -23,7 +23,15 @@ module.exports = function(User) {
return callback(new Error('[[error:you-cant-follow-yourself]]'));
}
User.isFollowing(uid, theiruid, function(err, isFollowing) {
if (err) {
return callback(err);
}
if (type === 'follow') {
if (isFollowing) {
return callback(new Error('[[error:already-following]]'));
}
var now = Date.now();
async.parallel([
async.apply(db.sortedSetAdd, 'following:' + uid, now, theiruid),
@@ -32,6 +40,9 @@ module.exports = function(User) {
async.apply(User.incrementUserFieldBy, theiruid, 'followerCount', 1)
], callback);
} else {
if (!isFollowing) {
return callback(new Error('[[error:not-following]]'));
}
async.parallel([
async.apply(db.sortedSetRemove, 'following:' + uid, theiruid),
async.apply(db.sortedSetRemove, 'followers:' + theiruid, uid),
@@ -39,6 +50,7 @@ module.exports = function(User) {
async.apply(User.decrementUserFieldBy, theiruid, 'followerCount', 1)
], callback);
}
});
}
User.getFollowing = function(uid, start, end, callback) {